fix(eslint): allow use method inside other use methods (QwikDev#3804)

fixes QwikDev#3787
Kesmek · Apr 17, 2023 · 26fa4a0 · 26fa4a0
1 parent 99c6b23
commit 26fa4a0
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 2 deletions.
diff --git a/packages/eslint-plugin-qwik/qwik.unit.ts b/packages/eslint-plugin-qwik/qwik.unit.ts
@@ -28,6 +28,33 @@ test('no-use-after-await', () => {
   ruleTester.run('my-rule', rules['use-method-usage'] as any, {
     valid: [
       `
+export function useSession1() {
+  useContext();
+}
+export function useSession2() {
+  return useContext();
+}
+export function useSession3() {
+  return useContext().value;
+}
+`,
+      `
+export const useSession1 = () => {
+  useContext();
+}
+
+export const useSession2 = () => {
+  return useContext();
+}
+
+export const useSession3 = () => useContext();
+
+export const useSession4 = () => useContext().value;
+
+export const useSession5 = () => useContext().value + 10;
+
+`,
+      `
       export const HelloWorld = component$(async () => {
           useMethod();
           await something();

diff --git a/packages/eslint-plugin-qwik/src/useMethodUsage.ts b/packages/eslint-plugin-qwik/src/useMethodUsage.ts
@@ -56,6 +56,7 @@ export const useMethodUsage: Rule.RuleModule = {
             case 'MemberExpression':
             case 'BinaryExpression':
             case 'UnaryExpression':
+            case 'ReturnStatement':
             case 'BlockStatement':
               break;
             case 'ArrowFunctionExpression':
@@ -87,9 +88,8 @@ export const useMethodUsage: Rule.RuleModule = {
                   node,
                   messageId: 'use-wrong-function',
                 });
-                return;
               }
-              break;
+              return;
             default:
               context.report({
                 node,