Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canary] Transcoding Support + More Image Format Support (JPEGXL) #3250

Open
wants to merge 49 commits into
base: canary
Choose a base branch
from
Open

[Canary] Transcoding Support + More Image Format Support (JPEGXL) #3250

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
e2a86c6
Add JXL Support.
maxpiva Aug 15, 2024
cb647ad
Make sure if djxl do not exists, continue as usual.
maxpiva Aug 15, 2024
7f6db24
Changed the way conversion happens.
maxpiva Aug 23, 2024
dd0021a
Missing file
maxpiva Aug 23, 2024
efc14ff
Merge branch 'Kareadita:develop' into develop
maxpiva Aug 23, 2024
9d48664
Revert "Changed the way conversion happens."
maxpiva Aug 26, 2024
cf05e5f
Reapply "Changed the way conversion happens."
maxpiva Aug 26, 2024
4902a74
Changed the way conversion happens.
maxpiva Aug 23, 2024
21b4c1b
Merge with Karedita
maxpiva Aug 26, 2024
7d48f6e
Add Documentation
maxpiva Aug 27, 2024
a4a12a1
FIX BOMS
maxpiva Aug 28, 2024
0f98d75
Recode SupportedImageTypesFromRequest removing possible errors.
maxpiva Aug 28, 2024
937f89c
Remove own docker build
maxpiva Aug 28, 2024
a08a795
Shell Call no longer used, since swapped image conversion to Image Ma…
maxpiva Aug 28, 2024
bc8481c
Merge branch 'Kareadita:develop' into JPEG-XL_JPG2000_HEIF
maxpiva Aug 29, 2024
e7f021a
Edit CodeStyle
maxpiva Aug 29, 2024
c624287
Remove custom docker builder
maxpiva Aug 29, 2024
6dbeaf1
Fixed discovered issues.
maxpiva Aug 30, 2024
fead3f6
Merge branch 'Kareadita:develop' into JPEG-XL_JPG2000_HEIF
maxpiva Sep 19, 2024
bf30989
Merge branch 'Kareadita:develop' into JPEG-XL_JPG2000_HEIF
maxpiva Sep 27, 2024
0cc4803
Removed NetVips and ImageSharp (Use only ImageMagick)
maxpiva Sep 28, 2024
10da91c
Remove CropFromDimensions (Geometry will take care)
maxpiva Sep 28, 2024
1541d6a
BOM Changes
maxpiva Sep 28, 2024
23a9aa8
Delete .bak
maxpiva Sep 28, 2024
b6a986a
Bug fixes.
maxpiva Sep 29, 2024
3008ae0
Merge branch 'Kareadita:develop' into RemoveSixLaborsAndNetVips
maxpiva Sep 29, 2024
9bf1fa8
Added SmartCrop (port from smartcrop.js)
maxpiva Oct 1, 2024
170c3b6
Refactor and cleanup.
maxpiva Oct 4, 2024
361c464
BOM Fixes
maxpiva Oct 4, 2024
d6056b8
Update docker-build.sh
maxpiva Oct 4, 2024
92f131a
Fixed Benchmarks
maxpiva Oct 4, 2024
b21ee66
Merge branch 'RemoveSixLaborsAndNetVips' of https://github.com/maxpiv…
maxpiva Oct 4, 2024
4f026e6
Fixed BOM
maxpiva Oct 4, 2024
00ee60b
Requested changes.
maxpiva Oct 10, 2024
fbbbbb8
Removed bak files, fixed EncodeFormat BOM
maxpiva Oct 10, 2024
a0f804b
Removed quality parameter everywhere.
maxpiva Oct 11, 2024
11749bd
Remove quality parameters after refactor.
maxpiva Oct 15, 2024
edbd44b
Bump versions by dotnet-bump-version.
majora2007 Oct 24, 2024
1a88dd4
Lots of Bugfixes (#3308)
majora2007 Oct 25, 2024
7159f40
Added Support for Q8 and Q16 ImageMagick
maxpiva Dec 10, 2024
81c04ad
Merge from develop
maxpiva Dec 10, 2024
dd33037
Merge branch 'Kareadita-develop' into RemoveSixLaborsAndNetVips
maxpiva Dec 10, 2024
9d94ecf
Fix GetRGBAColors Q8 Bug
maxpiva Dec 11, 2024
d1411c1
Merge pull request #2 from Kareadita/develop
maxpiva Dec 11, 2024
d84f07e
FIX BOMs
maxpiva Dec 11, 2024
87e976d
FIX BOMS
maxpiva Dec 11, 2024
44dc556
FIX BOMs
maxpiva Dec 11, 2024
872e64d
Merged with Canaryu
maxpiva Dec 11, 2024
9dccb2d
Merge branch 'Kareadita-canary' into RemoveSixLaborsAndNetVips
maxpiva Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove quality parameters after refactor.
  • Loading branch information
@maxpiva
maxpiva committed Oct 15, 2024
commit 11749bd5c48a807a99667f3bc4a40c8fa4cd1f87
2 changes: 1 addition & 1 deletion API/Extensions/EncodeFormatExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public static int DefaultQuality(this EncodeFormat encodeFormat)
{
return encodeFormat switch
{
EncodeFormat.PNG => 100, // (Image Magick Maximum Deflate Compression) (In case of PNG, png is always lossless, Quality indicate the compression level)
EncodeFormat.PNG => 100, // (Image Magick Maximum Deflate Compression) (In case of PNG, png is always lossless, Quality indicates the compression level)
EncodeFormat.WEBP => 100,
EncodeFormat.AVIF => 100,
EncodeFormat.JPEG => 99, // (Best Compression speed, with almost no visual quality loss)
Expand Down
4 changes: 0 additions & 4 deletions API/Services/ImageServices/IImage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,23 +63,20 @@ public interface IImage : IDisposable
/// </summary>
/// <param name="filename">The name of the file to save the image to.</param>
/// <param name="format">The format to save the image in.</param>
/// <param name="quality">The quality of the saved image.</param>
void Save(string filename, EncodeFormat format);

/// <summary>
/// Saves the image to the specified stream with the specified format and quality.
/// </summary>
/// <param name="stream">The stream to save the image to.</param>
/// <param name="format">The format to save the image in.</param>
/// <param name="quality">The quality of the saved image.</param>
void Save(Stream stream, EncodeFormat format);

/// <summary>
/// Asynchronously saves the image to the specified file with the specified format and quality.
/// </summary>
/// <param name="filename">The name of the file to save the image to.</param>
/// <param name="format">The format to save the image in.</param>
/// <param name="quality">The quality of the saved image.</param>
/// <param name="token">The cancellation token.</param>
/// <returns>A task representing the asynchronous save operation.</returns>
Task SaveAsync(string filename, EncodeFormat format, CancellationToken token = default);
Expand All @@ -89,7 +86,6 @@ public interface IImage : IDisposable
/// </summary>
/// <param name="stream">The stream to save the image to.</param>
/// <param name="format">The format to save the image in.</param>
/// <param name="quality">The quality of the saved image.</param>
/// <param name="token">The cancellation token.</param>
/// <returns>A task representing the asynchronous save operation.</returns>
Task SaveAsync(Stream stream, EncodeFormat format, CancellationToken token = default);
Expand Down