Skip to content
This repository has been archived by the owner on May 16, 2020. It is now read-only.

Support dpi native type rowid #121

Merged
merged 13 commits into from
Jul 30, 2019
Merged

Support dpi native type rowid #121

merged 13 commits into from
Jul 30, 2019

Conversation

KarlKeiser
Copy link
Contributor

@KarlKeiser KarlKeiser commented Jul 29, 2019 •
edited
Loading

fixes #117

@KarlKeiser KarlKeiser requested review from c-bik and acautin July 29, 2019 08:06
acautin
acautin previously approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@acautin acautin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine reading rowid columns using getQueryValue 👍

@acautin
Copy link
Contributor

acautin commented Jul 29, 2019

Tested with long rowids and it is also working correctly.

c-bik
c-bik suggested changes Jul 30, 2019
View reviewed changes
test/oranif_eunit.erl Show resolved Hide resolved
c_src/dpiData_nif.c Outdated Show resolved Hide resolved
@c-bik c-bik merged commit 628c505 into master Jul 30, 2019
@c-bik c-bik deleted the support-DPI_NATIVE_TYPE_ROWID branch July 30, 2019 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@c-bik c-bik c-bik approved these changes

@acautin acautin acautin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing support for DPI_NATIVE_TYPE_ROWID
3 participants
@KarlKeiser @acautin @c-bik