Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heads up about test error on 1.3 #21

Closed
KristofferC opened this issue Sep 6, 2019 · 1 comment
Closed

Heads up about test error on 1.3 #21

KristofferC opened this issue Sep 6, 2019 · 1 comment

Comments

@KristofferC
Copy link

When testing this package against the upcoming 1.3 release, the following test error occured:

Error During Test at /root/.julia/packages/KrylovKit/kSkwM/test/linalg.jl:57
  Got exception outside of a @test
  MethodError: no method matching hschur!(::UpperHessenberg{Float32,Array{Float32,2}})
  ...
  Stacktrace:
   [1] top-level scope at /root/.julia/packages/KrylovKit/kSkwM/test/linalg.jl:61
   [2] top-level scope at /workspace/srcdir/julia/usr/share/julia/stdlib/v1.3/Test/src/Test.jl:1180
   [3] top-level scope at /root/.julia/packages/KrylovKit/kSkwM/test/linalg.jl:57
   [4] top-level scope at /workspace/srcdir/julia/usr/share/julia/stdlib/v1.3/Test/src/Test.jl:1107
   [5] top-level scope at /root/.julia/packages/KrylovKit/kSkwM/test/linalg.jl:57
   [6] include at ./boot.jl:328 [inlined]
   [7] include_relative(::Module, ::String) at ./loading.jl:1105
   [8] include(::Module, ::String) at ./Base.jl:31
   [9] include(::String) at ./client.jl:432
   [10] top-level scope at /root/.julia/packages/KrylovKit/kSkwM/test/runtests.jl:19
   [11] include at ./boot.jl:328 [inlined]
   [12] include_relative(::Module, ::String) at ./loading.jl:1105
   [13] include(::Module, ::String) at ./Base.jl:31
   [14] include(::String) at ./client.jl:432
   [15] top-level scope at none:6
   [16] eval(::Module, ::Any) at ./boot.jl:330
   [17] exec_options(::Base.JLOptions) at ./client.jl:271
   [18] _start() at ./client.jl:468

This is likely due to the PR JuliaLang/julia#31853 introducing the new UpperHessenberg type returned from some functions. Adding a specialization here might be enough to fix it.
@KristofferC KristofferC mentioned this issue Sep 6, 2019
Merged
36 tasks
@Jutho
Copy link
Owner

Jutho commented Sep 6, 2019

Thanks; that's easily fixed but now I run up against a bug in julia master, which I reported in this existing thread:

JuliaLang/LinearAlgebra.jl#661

@KristofferC KristofferC mentioned this issue Sep 19, 2019
Merged
18 tasks
@Jutho Jutho closed this as completed Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KristofferC @Jutho