Fix bug in model_response. Need to to call eltype on data columns

and not the symbol representing it.
JuliaStats · Jan 15, 2018 · 058048d · 058048d
1 parent 8caee95
commit 058048d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/modelframe.jl b/src/modelframe.jl
@@ -177,8 +177,9 @@ Extract the response column, if present.  `DataVector` or
 """
 function StatsBase.model_response(mf::ModelFrame)
     if mf.terms.response
-        T = Missings.T(eltype(mf.terms.eterms[1]))
-        convert(Array{T}, mf.df[mf.terms.eterms[1]])
+        _response = mf.df[mf.terms.eterms[1]]
+        T = Missings.T(eltype(_response))
+        convert(Array{T}, _response)
     else
         error("Model formula one-sided")
     end

diff --git a/test/modelmatrix.jl b/test/modelmatrix.jl
@@ -27,9 +27,8 @@ x3 = [13.:16;]
 x4 = [17.:20;]
 f = @formula(y ~ x1 + x2)
 mf = ModelFrame(f, d)
-## @test mm.response_colnames == ["y"] # nope: no response_colnames
 @test coefnames(mf) == ["(Intercept)","x1","x2"]
-## @test model_response(mf) == transpose([1. 2 3 4]) # fails: Int64 vs. Float64
+@test model_response(mf) == [1:4;]
 mm = ModelMatrix(mf)
 smm = ModelMatrix{sparsetype}(mf)
 @test mm.m[:,1] == ones(4)