-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Censored distribution #1470
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1470 +/- ##
==========================================
+ Coverage 84.26% 84.80% +0.54%
==========================================
Files 124 126 +2
Lines 7511 7778 +267
==========================================
+ Hits 6329 6596 +267
Misses 1182 1182
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I left some initial comments 🙂
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
We could add the patch version increment for a release too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you build the documentation locally and checked that it looks fine?
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Yes, all looks good. All changes have been incorporated and comments resolved, except for #1470 (comment). With recent changes, I replaced some special-casing in the expectations with a utility function |
This should be updated to use the new truncation syntax before merging. |
Co-authored-by: Moritz Schauer <moritzschauer@web.de>
Okay, this should be up-to-date with master again. |
@devmotion is anything else needed before merging this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for another great PR @sethaxen! I only have a minor suggestion regarding @check_args
. I'll approve nevertheless, I'm fine with merging after it is addressed 🙂
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
@devmotion okay then, should be good to merge! |
This PR fixes #1468 for constructing a right-, left-, or interval-censored form of a distribution.