Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default solver to Polyhedra backend #2195

Merged
merged 4 commits into from
Jul 13, 2020
Merged

Add default solver to Polyhedra backend #2195

merged 4 commits into from
Jul 13, 2020

Conversation

schillic
Copy link
Member

@schillic schillic commented Jun 25, 2020 •
edited
Loading

This is currently blocked by JuliaPolyhedra/Polyhedra.jl#217.
I made the test more robust.

@schillic schillic changed the title Add default solver to Polyhedra backend WIP Add default solver to Polyhedra backend Jun 25, 2020
@schillic schillic force-pushed the schillic/polyhedra branch from c546c13 to 5b380dd Compare June 27, 2020 05:09
@mforets
Copy link
Member

mforets commented Jul 5, 2020

This is currently blocked by JuliaPolyhedra/Polyhedra.jl#217.

ok so we should look into that.

@mforets mforets mentioned this pull request Jul 13, 2020
Merged
@schillic schillic changed the title WIP Add default solver to Polyhedra backend Add default solver to Polyhedra backend Jul 13, 2020
@schillic schillic requested a review from mforets July 13, 2020 19:24
mforets
mforets approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👏

@mforets
Copy link
Member

mforets commented Jul 13, 2020

let's tag a new minor release after merging this one.

@schillic
Copy link
Member Author

So should we wait?

@mforets mforets merged commit 6f0257d into master Jul 13, 2020
@mforets mforets deleted the schillic/polyhedra branch July 13, 2020 19:57
@schillic schillic mentioned this pull request Mar 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mforets mforets mforets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schillic @mforets