Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ARPACKException here from LinearAlgebra, fixes #64. #65

Merged
merged 2 commits into from
Apr 15, 2019
Merged

Move ARPACKException here from LinearAlgebra, fixes #64. #65

merged 2 commits into from
Apr 15, 2019

Conversation

fredrikekre
Copy link
Member

No description provided.

@fredrikekre fredrikekre mentioned this pull request Apr 12, 2019
Merged
@fredrikekre
Copy link
Member Author

Something changed in Julia 1.2/nightly ?

Symmetric generalized with singular B: Test Failed at /home/travis/build/JuliaLinearAlgebra/Arpack.jl/test/runtests.jl:104
  Expression: sort((eigs(A, B, nev=k, sigma=1.0))[1]) ≈ sort((eigvals(A, B))[1:k])
   Evaluated: [0.006464592231858357, 0.07795551662116051, 0.3120549427946556] ≈ [-Inf, 0.006464592231858268, 0.07795551662116144]

@coveralls
Copy link

coveralls commented Apr 12, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 115

  • 0 of 8 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.9%) to 65.357%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/libarpack.jl 0 8 0.0%
Totals Coverage Status
Change from base Build 98: -1.9%
Covered Lines: 183
Relevant Lines: 280
💛 - Coveralls

@andreasnoack
Copy link
Member

Hm. Would be good to figure out what is going on. We now sort the eigenvalues but it's not obvious why it should cause this test failure.

@fredrikekre
Copy link
Member Author

We now sort the eigenvalues but it's not obvious why it should cause this test failure.

Looks like that is the reason (JuliaLang/julia#21598), -Inf is now sorted first:

using Random, LinearAlgebra
Random.seed!(127);
n = 10;
k = 3;
A = randn(n,n); A = A'A;
B = randn(n,k); B = B*B';
eigvals(A, B)

results in

julia> eigvals(A, B)
10-element Array{Float64,1}:
    0.006464592231858268
    0.07795551662116144 
    0.312054942794673   
  Inf                   
  Inf                   
  Inf                   
  Inf                   
  Inf                   
  Inf                   
 -Inf

on Julia 1.0, 1.1 but in

julia> eigvals(A, B)
10-element Array{Float64,1}:
 -Inf                   
    0.006464592231858268
    0.07795551662116144 
    0.312054942794673   
  Inf                   
  Inf                   
  Inf                   
  Inf                   
  Inf                   
  Inf

on Julia 1.2/master.

@codecov-io
Copy link

codecov-io commented Apr 12, 2019 •
edited
Loading

Codecov Report

Merging #65 into master will decrease coverage by 0.61%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   67.27%   66.66%   -0.62%     
==========================================
  Files           2        2              
  Lines         272      297      +25     
==========================================
+ Hits          183      198      +15     
- Misses         89       99      +10
Impacted Files Coverage Δ
src/libarpack.jl 80.57% <0%> (-4.93%) ⬇️
src/Arpack.jl 54.43% <0%> (+4.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04defa4...1cf521b. Read the comment docs.

@fredrikekre fredrikekre merged commit 6c1bfec into master Apr 15, 2019
@fredrikekre fredrikekre deleted the fe/arpack-exc branch April 15, 2019 06:03
@fredrikekre fredrikekre mentioned this pull request May 15, 2019
Closed
58 tasks
@KristofferC KristofferC mentioned this pull request Sep 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasnoack andreasnoack andreasnoack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fredrikekre @coveralls @andreasnoack @codecov-io