Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL: don't complete str and cmd macros when the input matches the internal name like r_ to r" #56254

Merged
merged 4 commits into from
Oct 23, 2024
+23 −0
Merged

REPL: don't complete str and cmd macros when the input matches the internal name like r_ to r" #56254

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60b5bb5
don't complete string and command macros when the input matches the i…
IanButterworth Oct 20, 2024
34a0bdb
Update REPLCompletions.jl
IanButterworth Oct 20, 2024
b4cd72c
Merge branch 'master' into ib/repl_string_macro_completion
IanButterworth Oct 22, 2024
cc9f084
Merge branch 'master' into ib/repl_string_macro_completion
IanButterworth Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update REPLCompletions.jl
  • Loading branch information
@IanButterworth
IanButterworth authored Oct 20, 2024
commit 34a0bdbfa42ef84b99dd9a97243d1b2c7d75426d
2 changes: 1 addition & 1 deletion stdlib/REPL/src/REPLCompletions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ function append_filtered_mod_names!(ffunc::Function, suggestions::Vector{Complet
filter!(macros) do m
s = String(m)
if endswith(s, "_str") || endswith(s, "_cmd")
occursin(name, s[1:end-4])
occursin(name, first(s, length(s)-4))
else
true
end
Expand Down