Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports release 1.11 #55855

Merged
merged 10 commits into from
Sep 25, 2024
Merged

Backports release 1.11 #55855

merged 10 commits into from
Sep 25, 2024

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Sep 24, 2024

Backported PRs:

Need manual backport:

Contains multiple commits, manual intervention needed:

Non-merged PRs with backport label:

LilithHafner and others added 6 commits September 24, 2024 09:40
root cause:
if current dir has been deleted, then pwd() will throw an IOError:
pwd(): no such file or directory (ENOENT)

---------

Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
(cherry picked from commit 48ddd2d)
`%M` is the format specifier for the minutes, not the month (which
should be `%m`), and it was used twice.

Also, on macOS `Libc.strptime` internally calls `mktime` which depends
on the local timezone. We now temporarily set `TZ=UTC` to avoid
depending on the local timezone.

Fix #55827.

(cherry picked from commit d6fa66f)
This change protects `@assert` from invalidations to `Base.string(...)`
by adding an `invokelatest` barrier.

A common source of invalidations right now is `print(io,
join(args...))`. The problem is:
1. Inference concludes that `join(::Any...)` returns
`Union{String,AnnotatedString}`
2. The `print` call is union-split to `String` and `AnnotatedString`
3. This code is now invalidated when StyledStrings defines `print(io,
::AnnotatedString)`

The invalidation chain for `@assert` is similar: ` @Assert 1 == 1` calls
into `string(::Expr)` which calls into `print(io, join(args::Any...))`.
Unfortunately that leads to the invalidation of almost all `@assert`s
without an explicit error message

Similar to
#55583 (comment)

(cherry picked from commit 945517b)
@KristofferC KristofferC force-pushed the backports-release-1.11 branch from 578cb0f to 2259c79 Compare September 24, 2024 07:54
aviatesk and others added 3 commits September 24, 2024 21:56
…55783)

This version would be better as per this comment:
<#55739 (review)>
I confirmed this still allows us to avoid invalidations reported at
#55583.

(cherry picked from commit f808606)
#55453 is stuck on StyledStrings
and Base documentation being entangled and there isn't a good way to
have the documentation of Base types / methods live in an stdlib. This
is a stop gap solution to finally be able to move forwards with 1.11.

(cherry picked from commit db6d277)
Stdlib: Downloads
URL: https://github.com/JuliaLang/Downloads.jl.git
Stdlib branch: master
Julia branch: master
Old commit: 1061ecc
New commit: 89d3c7d
Julia version: 1.12.0-DEV
Downloads version: 1.6.0(It's okay that it doesn't match)
Bump invoked by: @KristofferC
Powered by:
[BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)

Diff:
JuliaLang/Downloads.jl@1061ecc...89d3c7d

```
$ git log --oneline 1061ecc..89d3c7d
89d3c7d fix cancelling upload requests (#259)
df33406 gracefully cancel a request (#256)
```

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
(cherry picked from commit c3af4fc)
@aviatesk aviatesk force-pushed the backports-release-1.11 branch from e341838 to 0e17bd7 Compare September 24, 2024 12:57
@tecosaur tecosaur added the release Release management and versioning. label Sep 24, 2024
@aviatesk
Copy link
Member

The cherry-picked commit for the parser fix seems to be broken? Currently this branch doesn't bootstrap:

➜ make -j8 && jlb -e 'using Pkg; Pkg.precompile()' && jlb --startup-file=no test/runtests.jl compiler staged reflection REPL/replcompletions opaque_closure
    LINK usr/lib/libjulia-codegen.1.11.dylib
    LINK usr/lib/libjulia-codegen.dylib
    JULIA usr/lib/julia/corecompiler.ji
error during bootstrap:
LoadError(at "compiler/compiler.jl" line 3: LoadError(at "compiler/optimize.jl" line 219: LoadError(at "compiler/ssair/passes.jl" line 1565: ErrorException("syntax: malformed expression"))))
jl_f_throw at ~/julia/julia5/src/builtins.c:579
jl_apply at ~/julia/julia5/src/julia.h:2157 [inlined]
do_call at ~/julia/julia5/src/interpreter.c:126
eval_stmt_value at ~/julia/julia5/src/interpreter.c:174
eval_body at ~/julia/julia5/src/interpreter.c:663
jl_interpret_toplevel_thunk at ~/julia/julia5/src/interpreter.c:821
top-level scope at compiler/ssair/passes.jl:1565
jl_toplevel_eval_flex at ~/julia/julia5/src/toplevel.c:943
...

@KristofferC KristofferC force-pushed the backports-release-1.11 branch from 5c4fc50 to 0e17bd7 Compare September 24, 2024 14:42
@KristofferC
Copy link
Member Author

I dropped it

@nsajko
Copy link
Contributor

nsajko commented Sep 24, 2024

Added a PR to update NEWS.md: #55858

Will update History.md on master if this gets merged.

xref #47790

xref #51747

xref #54953

---------

Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@KristofferC KristofferC merged commit a28592d into release-1.11 Sep 25, 2024
6 checks passed
@KristofferC KristofferC deleted the backports-release-1.11 branch September 25, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release management and versioning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.