TOML: Return Dates objects by default, even for explicit Parser
#55020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The doc-comment here strongly suggests this was intended to be a public interface (although not the most frequently used one), so this tries a bit harder to avoid breaking the Dates-related behavior here. This removes `DTParser`, which effectively behaved the way the existing `Parser()` behaved before JuliaLang#54755 As a side effect, this hides the `Base.TOML.Parser` type out of the way the public API.
topolarity
added a commit
to JuliaLang/Pkg.jl
that referenced
this pull request
Jul 3, 2024
This behavior had actually subtly changed with JuliaLang/julia#54755 so that this no longer returned Dates objects, but sticking to the public `TOML.Parser` interface should prevent that from being an issue after JuliaLang/julia#55020 lands.
topolarity
added a commit
to JuliaLang/Pkg.jl
that referenced
this pull request
Jul 3, 2024
This behavior had actually subtly changed with JuliaLang/julia#54755 so that this no longer returned Dates objects, but sticking to the public `TOML.Parser` interface should prevent that from being an issue after JuliaLang/julia#55020 lands.
topolarity
added a commit
to JuliaLang/Pkg.jl
that referenced
this pull request
Jul 3, 2024
This behavior had actually subtly changed with JuliaLang/julia#54755 so that this no longer returned Dates objects, but sticking to the public `TOML.Parser` interface should prevent that from being an issue after JuliaLang/julia#55020 lands.
|
Will it be confusing if I wonder if the only way to do this "properly" is to have two |
|
OK, I think I have a plan that'll work:
Let's handle (1) in #55017 and I'll close this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doc-comment here strongly suggests this was intended to be a public interface (although not the most frequently used one), so this tries a bit harder to avoid breaking the Dates-related behavior here.
This removes
DTParser, which effectively behaved the way the existingParser()behaved before #54755As a side effect, this hides the
Base.TOML.Parsertype out of the way the public API.