add variant of regex.jl:match() that updates idx #51546
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow `idx` to be a `Ref{Int}`, so it can be updated easily to always
point at the first character not yet matched. This is particularly
useful e.g. when writing parsers that repeatedly call `match()` as a token
scanner on the same string, allowing them to start the next match
right after the previous one, usually with the regex anchored to the
`idx` position with `\G`.
fixes JuliaLang#51429
brenhinkeller
added
strings
|
This seems like a rather odd API; I don't know offhand of any other Base functions which have C-style, An alternative approach could be to add a method to match(re::Regex, str::Union{String,SubString}, prev::RegexMatch) =
match(re, str, prev.offset + ncodeunits(prev.match))That doesn't introduce hidden side effects but it's also kind of unclear whether it's materially more ergonomic than the status quo. |
|
Note that in the next julia version (1.10) we'll already have this: julia> s = "abc def"
"abc def"
julia> m = match(r"\w+", s)
RegexMatch("abc")
julia> match(r"\w+", s, parentindices(m.match)[1][end] + 1)
RegexMatch("def")Specifically, SubString support is added to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
idxto be aRef{Int}, so it can be updated easily to always point at the first character not yet matched. This is particularly useful e.g. when writing parsers that repeatedly callmatch()as a token scanner on the same string, allowing them to start the next match right after the previous one, usually with the regex anchored to theidxposition with\G.fixes #51429