MersenneTwister: hash seeds like for Xoshiro
#51436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses a part of #37165: > It's common that sequential seeds for RNGs are not as independent as one might like. This clears out this problem for `MersenneTwister`, and makes it easy to add the same feature to other RNGs via a new `hash_seed` function, which replaces `make_seed`. This is an alternative to #37766.
rfourquet
force-pushed
the
rf/hash-seed
branch
from
496a3dd to
c2159e4
Compare
rfourquet
force-pushed
the
rf/hash-seed
branch
from
bf41be6 to
4f4ee83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a part of #37165:
This clears out this problem for
MersenneTwister, and makes it easy to add the same feature to other RNGs via a newhash_seedfunction, which replacesmake_seed.This is an alternative to #37766.
This is draft, as tests must be fixed to accomodate for the changes in random streams; as I'm planning for another change breaking the streams, I will try to stack both PRs to avoid having to fix tests twice in a row.EDIT: This was changed so as to not break the streams, so LinAlg tests should pass as is.