Enable deprecations for non-broadcasted Dates arithmetic. #49832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inkydragon
added
dates
inkydragon
commented
May 16, 2023
Comment on lines
494
to
495
| @test t2 - t1 == [Dates.Day(1) Dates.Day(31) Dates.Day(365); Dates.Day(365) Dates.Day(28) Dates.Day(1)] | ||
| @test t4 - t3 == [Dates.Millisecond(1000), Dates.Millisecond(60000), Dates.Millisecond(3600000)] |
There was a problem hiding this comment.
julia> typeof(t1)
Matrix{Date} (alias for Array{Date, 2})
julia> typeof(t2)
Matrix{Date} (alias for Array{Date, 2})
julia> methods(-, (Matrix{Date},Matrix{Date}))
# 1 method for generic function "-" from Base:
[1] -(A::AbstractArray, B::AbstractArray)
@ arraymath.jl:6Perhaps this usage is not deprecated.
| @test_deprecated "use `x .- y` instead" t1 - Dates.Day(1) | ||
| @test_deprecated "use `x .- y` instead" t3 - Dates.Hour(1) | ||
| @test_deprecated "use `x .- y` instead" t1 - (Dates.Month(1) + Dates.Day(1)) | ||
| @test_deprecated "use `x .- y` instead" t3 - (Dates.Hour(1) + Dates.Minute(1)) | ||
| @test t2 - t1 == [Dates.Day(1) Dates.Day(31) Dates.Day(365); Dates.Day(365) Dates.Day(28) Dates.Day(1)] | ||
| @test t4 - t3 == [Dates.Millisecond(1000), Dates.Millisecond(60000), Dates.Millisecond(3600000)] | ||
| @test (Dates.Date(2009, 1, 1):Dates.Week(1):Dates.Date(2009, 1, 21)) - (Dates.Date(2009, 1, 1):Dates.Day(1):Dates.Date(2009, 1, 3)) == [Dates.Day(0), Dates.Day(6), Dates.Day(12)] |
There was a problem hiding this comment.
julia> typeof((Dates.DateTime(2009, 1, 1, 1, 1, 1):Dates.Second(1):Dates.DateTime(2009, 1, 1, 1, 1, 3)))
StepRange{DateTime, Second}
julia> methods(-, (StepRange{DateTime, Second},StepRange{DateTime, Second}))
# 1 method for generic function "-" from Base:
[1] -(x::OrdinalRange{T}, y::OrdinalRange{T}) where T<:TimeType
@ Dates /mnt/v/julia/usr/share/julia/stdlib/v1.10/Dates/src/arithmetic.jl:95julia/stdlib/Dates/src/arithmetic.jl
Lines 94 to 96 in 78fbf1b
Perhaps this usage is not deprecated.
| @@ -92,6 +92,7 @@ end | |||
|
|
|||
| (*)(A::Period, B::AbstractArray) = Broadcast.broadcast_preserving_zero_d(*, A, B) | |||
| (*)(A::AbstractArray, B::Period) = Broadcast.broadcast_preserving_zero_d(*, A, B) | |||
| (/)(A::AbstractArray, B::Period) = Broadcast.broadcast_preserving_zero_d(/, A, B) | |||
There was a problem hiding this comment.
Shouldn't actually be deprecated, see #34786 (which tests this).
Originally posted by
@fredrikekrein #46093 (comment)
JeffBezanson
force-pushed
the
wo/dates-dep
branch
from
b36b483 to
390dfe4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #37814, replace #46093