Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the module specific names in names() instead of the binding #42532

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Use the module specific names in names() instead of the binding #42532

merged 1 commit into from
Nov 1, 2021

Conversation

Pangoraw
Copy link
Contributor

@Pangoraw Pangoraw commented Oct 7, 2021

As reported in #42527, the imported values that are aliased have their original name as binding->name (unlike the modules). However, the key of the binding table has the relevant name so this can be used in the names function to always get the aliased version.

Fixes #42527

@vchuravy vchuravy requested a review from JeffBezanson October 7, 2021 15:52
@JeffBezanson
Copy link
Member

Thanks, very helpful first PR!

@fredrikekre fredrikekre added backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Oct 10, 2021
@KristofferC KristofferC mentioned this pull request Oct 11, 2021
Merged
84 tasks
@Pangoraw Pangoraw mentioned this pull request Oct 18, 2021
Closed
This was referenced Oct 19, 2021
Merged
Merged
@KristofferC KristofferC force-pushed the aliased_bindings_42527 branch from cca058f to dec1727 Compare October 31, 2021 18:07
@KristofferC
Copy link
Member

Rebased to get another CI run.

@KristofferC KristofferC added the merge me PR is reviewed. Merge when all tests are passing label Oct 31, 2021
@DilumAluthge DilumAluthge merged commit 8d82176 into JuliaLang:master Nov 1, 2021
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Nov 1, 2021
@Pangoraw Pangoraw deleted the aliased_bindings_42527 branch November 1, 2021 07:01
KristofferC pushed a commit that referenced this pull request Nov 2, 2021
@Pangoraw @KristofferC
use the httable key instead of the binding name in jl_module_names (#…
b825b2d 
…42532)

(cherry picked from commit 8d82176)
KristofferC pushed a commit that referenced this pull request Nov 7, 2021
@Pangoraw @KristofferC
use the httable key instead of the binding name in jl_module_names (#…
3774d7b 
…42532)

(cherry picked from commit 8d82176)
KristofferC pushed a commit that referenced this pull request Nov 11, 2021
@Pangoraw @KristofferC
use the httable key instead of the binding name in jl_module_names (#…
362ffb5 
…42532)

(cherry picked from commit 8d82176)
KristofferC pushed a commit that referenced this pull request Nov 12, 2021
@Pangoraw @KristofferC
use the httable key instead of the binding name in jl_module_names (#…
0a50e14 
…42532)

(cherry picked from commit 8d82176)
@KristofferC KristofferC removed backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Nov 13, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@Pangoraw @LilithHafner
use the httable key instead of the binding name in jl_module_names (J…
a3b7927 
…uliaLang#42532)
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@Pangoraw @LilithHafner
use the httable key instead of the binding name in jl_module_names (J…
c265b9a 
…uliaLang#42532)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@Pangoraw @staticfloat
use the httable key instead of the binding name in jl_module_names (#…
1186071 
…42532)

(cherry picked from commit 8d82176)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

@JeffBezanson JeffBezanson JeffBezanson approved these changes

Assignees
No one assigned
Labels
modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

names does not include as-renamed import
6 participants
@Pangoraw @JeffBezanson @KristofferC @vtjnash @DilumAluthge @fredrikekre