Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round from zero support for non-BigFloats #41246

Merged
merged 14 commits into from
Apr 12, 2022
Merged

Round from zero support for non-BigFloats #41246

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
914c4c3
Added round method for RoundFromZero
jessymilare Jun 12, 2021
57cc756
Added div and rem methods for RoundFromZero
jessymilare Jun 12, 2021
687f4c1
Add docstrings that RoundFromZero requires Julia 1.8
jessymilare Sep 11, 2021
32ff0df
Merge branch 'master' into round_from_zero
stevengj Apr 7, 2022
93872d8
Update base/div.jl
stevengj Apr 7, 2022
7f759b3
Update base/div.jl
stevengj Apr 7, 2022
31211a3
Update base/div.jl
stevengj Apr 7, 2022
c9750a9
Update base/div.jl
stevengj Apr 7, 2022
1f11927
Update base/rounding.jl
stevengj Apr 7, 2022
2d28fc8
Update base/rounding.jl
stevengj Apr 7, 2022
13b29f1
added NEWS
stevengj Apr 7, 2022
8e55cc9
note broken BigFloat case
stevengj Apr 7, 2022
2b1067c
Update NEWS.md
giordano Apr 9, 2022
2b44273
Merge branch 'master' into round_from_zero
DilumAluthge Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
note broken BigFloat case
  • Loading branch information
@stevengj
stevengj authored Apr 7, 2022
commit 8e55cc9a196d8cea88c6134ff2471e3431348d1f
2 changes: 1 addition & 1 deletion test/numbers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2540,7 +2540,7 @@ end
@test isnan(rem(T(Inf), T(2), mode))
@test isnan(rem(T(1), T(NaN), mode))
# FIXME: The broken case erroneously returns -Inf
@test rem(T(4), floatmin(T) * 2, mode) == 0 broken=(T == BigFloat && mode == RoundUp)
@test rem(T(4), floatmin(T) * 2, mode) == 0 broken=(T == BigFloat && mode in (RoundUp,RoundFromZero))
end
@test isequal(rem(nextfloat(typemin(T)), T(2), RoundToZero), -0.0)
@test isequal(rem(nextfloat(typemin(T)), T(2), RoundNearest), -0.0)
Expand Down