Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Ability to change rounding mode for all floats (cf. #2976) #3149

Merged
merged 11 commits into from
Sep 2, 2013
Merged

RFC: Ability to change rounding mode for all floats (cf. #2976) #3149

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
95dbacb
Add rounding modes to normal floating point arithmetic
andrioni May 19, 2013
823b017
Add Float32 rounding mode tests
andrioni May 19, 2013
1a13239
Integrate the new rounding modes with BigFloats
andrioni May 19, 2013
451f21e
Export RoundAwayZero too (even though it only works for BigFloats)
andrioni May 19, 2013
4f6ee0f
Stop hardcoding the `fenv.h` constants
andrioni May 20, 2013
454f61a
Fix bug while parsing fenv_constants.h
andrioni May 20, 2013
5a064b7
Renaming of the rounding modes
andrioni Aug 27, 2013
54a4055
Fixes post-rebase
andrioni Aug 27, 2013
e314eba
Remove fenv_constants.jl, as it is auto-generated
andrioni Aug 28, 2013
285b238
Documentation for the rounding modes (manual + stdlib)
andrioni Aug 28, 2013
773b60e
Fix issue with fenv.h and Ubuntu 12.04
andrioni Aug 28, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes post-rebase
  • Loading branch information
@andrioni
andrioni committed Aug 27, 2013
commit 54a4055b6dd7ed93531552d25c083a0a25033ba6
1 change: 0 additions & 1 deletion base/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ include ../Make.inc

PCRE_CONST = 0x[0-9a-fA-F]+|[-+]?\s*[0-9]+

<<<<<<< HEAD
# These are all the values needed for the RawVersionInfo struct
version_string = $(shell cat ../VERSION)
commit = $(shell git rev-parse HEAD 2>/dev/null)
Expand Down
8 changes: 8 additions & 0 deletions base/fenv_constants.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
const JL_FE_UNDERFLOW = 0x0010
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file shouldn't be part of the commit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I thought I removed it, but now I see I just added the file to .gitignore. Done, thanks.

const JL_FE_OVERFLOW = 0x0008
const JL_FE_DIVBYZERO = 0x0004
const JL_FE_INVALID = 0x0001
const JL_FE_TONEAREST = 0x0000
const JL_FE_UPWARD = 0x0800
const JL_FE_DOWNWARD = 0x0400
const JL_FE_TOWARDZERO = 0x0c00
4 changes: 0 additions & 4 deletions base/sysimg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,10 +218,6 @@ include("graphics.jl")
include("profile.jl")
importall .Profile

# rounding utilities
include("rounding.jl")
importall .Rounding

include = include_from_node1

# prime method cache with some things we know we'll need right after startup
Expand Down