Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust gc-debug for new task interface #29559

Merged
merged 3 commits into from
Oct 9, 2018
Merged

Adjust gc-debug for new task interface #29559

merged 3 commits into from
Oct 9, 2018

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Oct 7, 2018

Split out unrelated changes from #29489.

@vchuravy vchuravy requested a review from vtjnash October 7, 2018 22:27
src/gc-debug.c Outdated
}
else
return;

if (ptls == ptls2 && ta == ptls2->current_task) {
// scan up to current `sp` for current thread and task
char *low = (char*)jl_get_frame_addr();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong.

Copy link
Contributor

@yuyichao yuyichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scope of low

vchuravy and others added 3 commits October 8, 2018 11:30
Co-authored-by: Valentin Churavy <v.churavy@gmail.com>
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@vchuravy vchuravy requested a review from yuyichao October 8, 2018 15:33
@ararslan ararslan added the GC Garbage collector label Oct 9, 2018
@vchuravy vchuravy merged commit 4016019 into master Oct 9, 2018
@vchuravy vchuravy deleted the vc/debug_tasks branch October 9, 2018 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GC Garbage collector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants