Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UCP option the default for regex matching #27189

Merged
merged 2 commits into from
May 22, 2018
Merged

Make UCP option the default for regex matching #27189

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fa763a
Fix Windows path regex
Keno May 21, 2018
0eecc46
Make UCP option the default for regex matching
Keno May 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix Windows path regex 
\w matches numbers as well (which are not valid drive letters) and will match unicode
characters once we turn on UCP.
  • Loading branch information
@Keno
Keno committed May 21, 2018
commit 7fa763aaf3fd60dc755a31f23a6b58307ee849c6
2 changes: 1 addition & 1 deletion base/path.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if Sys.isunix()
elseif Sys.iswindows()
const path_separator = "\\"
const path_separator_re = r"[/\\]+"
const path_absolute_re = r"^(?:\w+:)?[/\\]"
const path_absolute_re = r"^(?:[A-Za-z]+:)?[/\\]"
const path_directory_re = r"(?:^|[/\\])\.{0,2}$"
const path_dir_splitter = r"^(.*?)([/\\]+)([^/\\]*)$"
const path_ext_splitter = r"^((?:.*[/\\])?(?:\.|[^/\\\.])[^/\\]*?)(\.[^/\\\.]*|)$"
Expand Down