Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate similar(f, …) in favor of just dispatching directly on f(…) #26733

Merged
merged 5 commits into from
Apr 13, 2018
Merged

Deprecate similar(f, …) in favor of just dispatching directly on f(…) #26733

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
112b149
Deprecate `similar(f, axes)` to calling f directly... and implement a…
mbauman Mar 20, 2018
982b1a7
Remove AbstractArray constructors; just use dispatch on functions
mbauman Apr 6, 2018
db3751d
Add NEWS and deprecations for...
mbauman Apr 6, 2018
7a089d6
Make compiler test use a local function
mbauman Apr 11, 2018
4e04a95
Merge branch 'master' into mb/deprecatesimilarf
mbauman Apr 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make compiler test use a local function 
that has the known properties that we want to test. The important thing is not necessarily zeros -- it is a relatively complex function. The `Base.zeros` method tree temporarily breaks this test due to its numerous deprecations, but this will be resolved in the future.
  • Loading branch information
@mbauman
mbauman committed Apr 11, 2018
commit 7a089d661a2be3b5029dbd5d91982a6d9ff78272
16 changes: 14 additions & 2 deletions test/compiler/compiler.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,10 +514,22 @@ end
@test h18679() === nothing


# issue #5575
f5575() = zeros(Type[Float64][1], 1)
# issue #5575: inference with abstract types on a reasonably complex method tree
zeros5575(::Type{T}, dims::Tuple{Vararg{Any,N}}) where {T,N} = Array{T,N}(dims)
zeros5575(dims::Tuple) = zeros5575(Float64, dims)
zeros5575(::Type{T}, dims...) where {T} = zeros5575(T, dims)
zeros5575(a::AbstractArray) = zeros5575(a, Float64)
zeros5575(a::AbstractArray, ::Type{T}) where {T} = zeros5575(a, T, size(a))
zeros5575(a::AbstractArray, ::Type{T}, dims::Tuple) where {T} = zeros5575(T, dims)
zeros5575(a::AbstractArray, ::Type{T}, dims...) where {T} = zeros5575(T, dims)
zeros5575(dims...) = zeros5575(dims)
f5575() = zeros5575(Type[Float64][1], 1)
@test Base.return_types(f5575, ())[1] == Vector

g5575() = zeros(Type[Float64][1], 1)
@test_broken Base.return_types(g5575, ())[1] == Vector # This should be fixed by removing deprecations


# make sure Tuple{unknown} handles the possibility that `unknown` is a Vararg
function maybe_vararg_tuple_1()
x = Any[Vararg{Int}][1]
Expand Down