Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change find() to return the same index type as pairs() #24774

Merged
merged 4 commits into from
Jan 10, 2018
Merged

Change find() to return the same index type as pairs() #24774

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a16323e
Change find() to return the same index type as pairs()
nalimilan Nov 25, 2017
dee7afd
Add NEWS entry
nalimilan Jan 6, 2018
b286f17
Also return indices from keys() for AbstractString, Tuple and NamedTu…
nalimilan Jan 7, 2018
8e605fb
Merge branch 'master' into nl/find
JeffBezanson Jan 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'master' into nl/find
  • Loading branch information
@JeffBezanson
JeffBezanson authored Jan 9, 2018
commit 8e605fb88a1856eb9f6c143c9fd733cd9f39192d
14 changes: 13 additions & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,9 +368,21 @@ This section lists changes that do not have deprecation warnings.
* `find` now returns the same type of indices as `keys`/`pairs` for `AbstractArray`,
`AbstractDict`, `AbstractString`, `Tuple` and `NamedTuple` objects ([#24774]).
In particular, this means that it returns `CartesianIndex` objects for matrices
and higher-dimensional arrays instead of linear indices as it was previously the case.
and higher-dimensional arrays instead of linear indices as was previously the case.
Use `Int[LinearIndices(size(a))[i] for i in find(f, a)]` to compute linear indices.

* `AbstractSet` objects are now considered equal by `==` and `isequal` if all of their
elements are equal ([#25368]). This has required changing the hashing algorithm
for `BitSet`.

* the default behavior of `titlecase` is changed in two ways ([#23393]):
+ characters not starting a word are converted to lowercase;
a new keyword argument `strict` is added which
allows to get the old behavior when it's `false`.
+ any non-letter character is considered as a word separator;
to get the old behavior (only "space" characters are considered as
word separators), use the keyword `wordsep=isspace`.

Library improvements
--------------------

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.