convert more Union(...) to Union{...} instances that escaped #11432 #12606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -700,7 +700,7 @@ imply multiplication: | |||
| julia> (x-1)(x+1) | |||
| ERROR: MethodError: `call` has no method matching call(::Int64, ::Int64) | |||
| Closest candidates are: | |||
| Union(!Matched::Any...) | |||
| Union{!Matched::Any...} | |||
There was a problem hiding this comment.
Are you also changing the printing here? If not then this'll make the doctest fail.
There was a problem hiding this comment.
fixed; I'm not sure how to change the printing, so I just left the docs with parens for now
There was a problem hiding this comment.
i think this one just happens to be a bit strange, and the parens are actually fairly correct (since it is specifically matching call(::Type{Union}, args...) = Union{args...} in essentials.jl:9). I think the bigger confusion there comes from the printing of call in prefix notation, but without the indication that the function itself didn't actually match.
vtjnash
added a commit
that referenced
this pull request
Aug 14, 2015
convert more Union(...) to Union{...} instances that escaped #11432
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just cleans up more usages of
Union(...)that have crept in since #11432 (or were never fixed).