Update isgreater from review

- Explicitly cache `x == x` to save the compiler some work. - Rename _is_unorderable to !_is_reflexive.
JuliaLang · Nov 21, 2020 · e4ac3bb · e4ac3bb
1 parent 4a9c5fb
commit e4ac3bb
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/base/operators.jl b/base/operators.jl
@@ -183,8 +183,10 @@ smallest.
 # Implementation
 Types should not usually implement this function. Instead, implement `isless`.
 """
-isgreater(a, b) = _is_unorderable(a) || _is_unorderable(b) ? isless(a, b) : isless(b, a)
-_is_unorderable(x) = !isa(x == x, Bool) || x != x
+isgreater(x, y) = _is_reflexive(x) && _is_reflexive(y) ? isless(y, x) : isless(x, y)
+_is_reflexive(x) = let eq = x == x
+    isa(eq, Bool) && eq
+end