Deprecate flipud() and fliplr() in favor of flipdim()

We do not provide other convenience functions for any other operation, like size(), and these names are obscure for non-MATLAB users.
JuliaLang · Mar 8, 2015 · 944c16d · 944c16d
1 parent b80f7db
commit 944c16d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/base/deprecated.jl b/base/deprecated.jl
@@ -294,6 +294,9 @@ const base64 = base64encode
 # 10314
 @deprecate filter!(r::Regex, d::Dict) filter!((k,v)->ismatch(r,k), d)
 
+@deprecate flipud(A::AbstractArray) flipdim(A, 1)
+@deprecate fliplr(A::AbstractArray) flipdim(A, 2)
+
 # 0.4 discontinued functions
 
 @noinline function subtypetree(x::DataType, level=-1)

diff --git a/base/dsp.jl b/base/dsp.jl
@@ -163,7 +163,7 @@ function xcorr(u, v)
     elseif sv < su
         v = [v;zeros(eltype(v),su-sv)]
     end
-    flipud(conv(flipud(u), v))
+    flipdim(conv(flipdim(u, 1), v), 1)
 end
 
 fftshift(x) = circshift(x, div([size(x)...],2))