Explicitly import Libdl #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
......okay apparently nightlies are a bit behind. I guess we'll wait on this until I fix the nightlies. |
JuliaLang/julia#25459 moved `Libdl` to the stdlib, which means that we need to explicitly import it now before we can do things like `Libdl.dlopen()`.
|
Okay great, these are passing now, and it's just #120 killing things on 0.7. |
|
Thanks for the PR! I fixed the other issue; so hopefully master is good now again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JuliaLang/julia#25459 moved
Libdlto the stdlib, which means that we need to explicitly import it now before we can do things likeLibdl.dlopen().Note that this is essentially a no-op on Julia 0.6, so this shouldn't break anything. (We'll see if CI agrees with me there)