Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Multi handle to NULL after calling curl_multi_cleanup #266

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Set Multi handle to NULL after calling curl_multi_cleanup #266

merged 1 commit into from
Jan 5, 2025

Conversation

giordano
Copy link
Contributor

@giordano giordano commented Jan 4, 2025

Fix #260.

@codecov Codecov
Copy link

codecov bot commented Jan 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.53%. Comparing base (afd04be) to head (2aaaddb).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/Curl/Multi.jl 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
- Coverage   90.68%   90.53%   -0.15%     
==========================================
  Files           5        5              
  Lines         612      613       +1     
==========================================
  Hits          555      555              
- Misses         57       58       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tecosaur
tecosaur approved these changes Jan 4, 2025
View reviewed changes
Copy link

@tecosaur tecosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straighforward 👍

This was referenced Jan 4, 2025
Merged
Merged
@giordano
Copy link
Contributor Author

giordano commented Jan 5, 2025

Thanks for the review!

As mentioned at #267 (comment), all tests pass for me on JuliaLang/julia#56951 with this PR and #267.

@giordano giordano merged commit e692e77 into master Jan 5, 2025
18 of 20 checks passed
@giordano giordano deleted the mg/fix-curl-multi-assign-segfault branch January 5, 2025 00:51
@valeriupredoi valeriupredoi mentioned this pull request Jan 6, 2025
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tecosaur tecosaur tecosaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calls curl_multi_assign with null
2 participants
@giordano @tecosaur