v0.6 precompile error: new UnionAll type breaks things #65

ghost · 2017-01-17T02:54:13Z

INFO: Precompiling module ColorTypes.
ERROR: LoadError: LoadError: MethodError: no method matching subtypes(::Type{ColorTypes.Color})
Closest candidates are:
  subtypes(::Module, ::DataType) at reflection.jl:316
  subtypes(::DataType) at reflection.jl:333
Stacktrace:
 [1] include_from_node1(::String) at ./loading.jl:532
 [2] include(::String) at ./sysimg.jl:14
 [3] include_from_node1(::String) at ./loading.jl:532
 [4] include(::String) at ./sysimg.jl:14
 [5] anonymous at ./<missing>:2
while loading /home/joe/.julia/v0.6/ColorTypes/src/types.jl, in expression starting on line 417
while loading /home/joe/.julia/v0.6/ColorTypes/src/ColorTypes.jl, in expression starting on line 56

can be fixed with:

const color3types = filter(x->(!x.abstract && length(fieldnames(x))>1), union(subtypes(Color{T,N}) where T where N, subtypes(AbstractRGB{T}) where T))

but then it fails again on

INFO: Precompiling module ColorTypes.
ERROR: LoadError: LoadError: type UnionAll has no field name
Stacktrace:
 [1] macro expansion; at /home/joe/.julia/v0.6/ColorTypes/src/types.jl:555 [inlined]
 [2] anonymous at ./<missing>:?
 [3] include_from_node1(::String) at ./loading.jl:532
 [4] include(::String) at ./sysimg.jl:14
 [5] include_from_node1(::String) at ./loading.jl:532
 [6] include(::String) at ./sysimg.jl:14
 [7] anonymous at ./<missing>:2
while loading /home/joe/.julia/v0.6/ColorTypes/src/types.jl, in expression starting on line 532
while loading /home/joe/.julia/v0.6/ColorTypes/src/ColorTypes.jl, in expression starting on line 56

The text was updated successfully, but these errors were encountered:

ghost · 2017-01-17T03:05:02Z

can be fixed with

for (C, acol, cola) in [(DIN99d{T}, :ADIN99d, :DIN99dA),
                        (DIN99o{T}, :ADIN99o, :DIN99oA),
                        (DIN99{T}, :ADIN99, :DIN99A),
                        (HSI{T}, :AHSI, :HSIA),
                        (HSL{T}, :AHSL, :HSLA),
                        (HSV{T}, :AHSV, :HSVA),
                        (LCHab{T}, :ALCHab, :LCHabA),
                        (LCHuv{T}, :ALCHuv, :LCHuvA),
                        (LMS{T}, :ALMS, :LMSA),
                        (Lab{T}, :ALab, :LabA),
                        (Luv{T}, :ALuv, :LuvA),
                        (XYZ{T}, :AXYZ, :XYZA),
                        (YCbCr{T}, :AYCbCr, :YCbCrA),
                        (YIQ{T}, :AYIQ, :YIQA),
                        (xyY{T}, :AxyY, :xyYA),
                        (BGR{T}, :ABGR, :BGRA),
                        (RGB{T}, :ARGB, :RGBA),
                        (Gray{T}, :AGray, :GrayA)] where T

but then fails in color_type and base_colorant_type

ghost · 2017-01-17T05:53:07Z

Subtypes() should accept UnionAll, not sure about everything else :(
JuliaLang/julia#20084

JeffBezanson · 2017-01-17T06:53:19Z

subtypes(AbstractRGB{T}) where T

This should not work --- an array of types is not a valid type. I'll add an error for this.

timholy · 2017-01-17T11:05:16Z

ColorTypes is basically a poster child for the kind of package that could benefit from the type revisions (e.g.,

ColorTypes.jl/src/traits.jl

Lines 177 to 257 in a0f9898

    
           """ 
        
            `ccolor` ("concrete color") helps write flexible methods. The idea is 
        
           that users may write `convert(HSV, c)` or even `convert(Array{HSV}, 
        
           A)` without specifying the element type explicitly (e.g., 
        
           `convert(Array{HSV{Float32}}, A)`). `ccolor` implements the logic "choose the 
        
           user's eltype if specified, otherwise retain the eltype of the source 
        
           object." However, when the source object has FixedPoint element type, 
        
           and the destination only supports AbstractFloat, we choose Float32. 
        
           Usage: 
        
               ccolor(desttype, srctype) -> concrete desttype 
        
           Example: 
        
               convert{C<:Colorant}(::Type{C}, p::Colorant) = cnvt(ccolor(C,typeof(p)), p) 
        
           where `cnvt` is the function that performs explicit conversion. 
        
           """ 
        
           ccolor{   Csrc<:Colorant}(::Type{Colorant   }, ::Type{Csrc}) = Csrc 
        
           ccolor{T, Csrc<:Colorant}(::Type{Colorant{T}}, ::Type{Csrc}) = base_colorant_type(Csrc){T} 
        
           ccolor{T, Csrc<:Color3  }(::Type{Colorant{T,3}}, ::Type{Csrc}) = Csrc 
        
           ccolor{T, Csrc<:Transparent3}(::Type{Colorant{T,3}}, ::Type{Csrc}) = base_color_type(Csrc) 
        
           ccolor{   Csrc<:Colorant}(::Type{Color   }, ::Type{Csrc}) = color_type(Csrc) 
        
           ccolor{T, Csrc<:Colorant}(::Type{Color{T}}, ::Type{Csrc}) = base_color_type(Csrc){T} 
        
           ccolor{Csrc<:Color}(::Type{TransparentColor}, ::Type{Csrc}) = 
        
                     error("Ambiguous storage order, choose AlphaColor or ColorAlpha") 
        
           ccolor{C<:Color,    Csrc<:Color}( 
        
                  ::Type{TransparentColor{C    }}, ::Type{Csrc}) = 
        
                      error("Ambiguous storage order, choose AlphaColor or ColorAlpha") 
        
           ccolor{C<:Color,T,  Csrc<:Color}( 
        
                  ::Type{TransparentColor{C,T  }}, ::Type{Csrc}) = 
        
                      error("Ambiguous storage order, choose AlphaColor or ColorAlpha") 
        
           ccolor{C<:Color,T,N,Csrc<:Color}( 
        
                  ::Type{TransparentColor{C,T,N}}, ::Type{Csrc}) = 
        
                      error("Ambiguous storage order, choose AlphaColor or ColorAlpha") 
        
           ccolor{Csrc<:TransparentColor}(::Type{TransparentColor}, ::Type{Csrc}) = Csrc 
        
           ccolor{Csrc<:Colorant}(::Type{AlphaColor}, ::Type{Csrc}) = alphacolor(Csrc) 
        
           ccolor{C<:Color,    Csrc<:Colorant}( 
        
                  ::Type{AlphaColor{C    }}, ::Type{Csrc}) = ccolor(alphacolor(C), Csrc) 
        
           ccolor{C<:Color,T,  Csrc<:Colorant}( 
        
                  ::Type{AlphaColor{C,T  }}, ::Type{Csrc}) = ccolor(alphacolor(C){T}, Csrc) 
        
           ccolor{C<:Color,T,N,Csrc<:Colorant}( 
        
                  ::Type{AlphaColor{C,T,N}}, ::Type{Csrc}) = ccolor(alphacolor(C){T}, Csrc) 
        
           ccolor{Csrc<:Colorant}(::Type{ColorAlpha}, ::Type{Csrc}) = coloralpha(Csrc) 
        
           ccolor{C<:Color,    Csrc<:Colorant}( 
        
                  ::Type{ColorAlpha{C    }}, ::Type{Csrc}) = ccolor(coloralpha(C), Csrc) 
        
           ccolor{C<:Color,T,  Csrc<:Colorant}( 
        
                  ::Type{ColorAlpha{C,T  }}, ::Type{Csrc}) = ccolor(coloralpha(C){T}, Csrc) 
        
           ccolor{C<:Color,T,N,Csrc<:Colorant}( 
        
                  ::Type{ColorAlpha{C,T,N}}, ::Type{Csrc}) = ccolor(coloralpha(C){T}, Csrc) 
        
           ccolor{  Csrc<:AbstractRGB}(::Type{AbstractRGB},    ::Type{Csrc}) = Csrc 
        
           ccolor{T,Csrc<:AbstractRGB}(::Type{AbstractRGB{T}}, ::Type{Csrc}) = base_colorant_type(Csrc){T} 
        
           # Generic concrete types 
        
           ccolor{Cdest<:Colorant,Csrc<:Colorant}(::Type{Cdest}, ::Type{Csrc}) = _ccolor(Cdest, Csrc, pick_eltype(Cdest, eltype(Cdest), eltype(Csrc))) 
        
           ccolor{Cdest<:AbstractGray,T<:Number}(::Type{Cdest}, ::Type{T}) = _ccolor(Cdest, Gray, pick_eltype(Cdest, eltype(Cdest), T)) 
        
           _ccolor{Cdest,Csrc,T<:Number}(::Type{Cdest}, ::Type{Csrc}, ::Type{T}) = base_colorant_type(Cdest){T} 
        
           _ccolor{Cdest,Csrc}(          ::Type{Cdest}, ::Type{Csrc}, ::Any)     = Cdest 
        
           # Specific concrete types 
        
           ccolor{Csrc<:Colorant}(::Type{RGB24},   ::Type{Csrc}) = RGB24 
        
           ccolor{Csrc<:Colorant}(::Type{ARGB32},  ::Type{Csrc}) = ARGB32 
        
           ccolor{Csrc<:Colorant}(::Type{Gray24},  ::Type{Csrc}) = Gray24 
        
           ccolor{Csrc<:Colorant}(::Type{AGray32}, ::Type{Csrc}) = AGray32 
        
           pick_eltype{C,T1<:Number,T2<:Number}(::Type{C}, ::Type{T1}, ::Type{T2}) = T1 
        
           pick_eltype{C}(::Type{C}, ::Any, ::Any) = eltypes_supported(C) 
        
           if VERSION >= v"0.5.0-dev+755" 
        
               pick_eltype{C,T2<:Number}(::Type{C}, ::Any, ::Type{T2}) = issupported(C, T2) ? T2 : eltype_default(C) 
        
           else 
        
               @generated function pick_eltype{C,T2<:Number}(::Type{C}, ::Any, ::Type{T2}) 
        
                   issupported(C, T2) ? :(T2) : :(eltype_default(C)) 
        
               end 
        
           end

and https://github.com/JuliaGraphics/ColorTypes.jl/blob/master/src/conversions.jl). At some point it will be interesting to rewrite it for the new capabilities.

Keno · 2017-01-17T21:15:03Z

I have a work in progress for this package.

Keno · 2017-01-17T21:15:54Z

https://gist.github.com/Keno/4f963f43ec128b2e9aa6eb2598fbb7c0

Keno · 2017-01-17T21:17:08Z

The last status was that I hit JuliaLang/julia#18457 (comment).

timholy · 2017-01-17T21:21:46Z

I also remember (I think) there being a number of places that could have benefited from triangular dispatch, which I think I worked around by expanding the number of arguments in several places. E.g.,

foo{C<:Colorant}(::Type{C}) = _foo(C, eltype(C))
# and now _foo can dispatch on both C and T where e.g. C = RGB{Float32}, T = Float32

tlnagy · 2017-01-21T01:41:53Z

Any progress on this? This breaks all dependent packages on 0.6 (including gadfly).

juliohm · 2017-01-23T17:05:01Z

This is also breaking ImageQuilting.jl on Julia v0.6.

SimonDanisch · 2017-01-23T17:33:25Z

this breaks basically everything :P

julia> Pkg.dependents("Colors")
50-element Array{AbstractString,1}:
 "Luxor"           
 "Images"          
 "ImageFiltering"  
 "VoronoiDelaunay" 
 "NamedColors"     
 "PlotUtils"       
 "VLFeat"          
 "Qwt"             
 "ProteinEnsembles"
 "Cairo"           
 ⋮                 
 "QuartzImageIO"   
 "GraphPlot"       
 "ImageView"       
 "Brim"            
 "ColorBrewer"     
 "Winston"         
 "Caesar"          
 "FaceDatasets"    
 "Bio"

Keno · 2017-01-24T20:39:57Z

I have a branch of julia/ColorTypes that passes here. However, I'll be traveling for the rest of the week, so I'm not gonna be able to clean this up. So here's the deal: I'll put up what I have in it's messy state (over the next hour or so), but with what I believe are all the tricky issues worked out and somebody can pick it up and finish it off. Otherwise, I'll get to it next week. I also have a PR for FixedPointNumbers, which this depends on. Same deal.

timholy · 2017-01-24T20:51:37Z

Sounds good to me. I can't promise to get to it very quickly, but I might, and of course there seem to be other volunteers in this thread who could tackle it.

Maybe easiest if you push as a branch rather than a gist?

Keno · 2017-01-24T20:58:02Z

Pushed as kf/06 here and as a PR on FixedPointNumbers. This also requires my kf/newreflection branch of Julia itself.

lobingera · 2017-01-31T09:16:58Z

@Keno Any idea what will happen with JuliaLang/julia#20006? Simon is unfortunately right: ColorTypes.jl breaks an awful lot of testing on 0.6

timholy · 2017-01-31T10:36:42Z

Looks like it's actively being worked on. These type-system issues aren't simple. You could disable testing on nightly if the failures really bother you.

Keno · 2017-01-31T14:04:57Z

It's through review. I'll merge it as soon as it's green on CI. Looks like the latest set of changes broke sth.

timholy · 2017-01-31T14:30:40Z

That's awesome. Don't worry about the breakages, I can take a peek. Really appreciate your help on this.

Keno · 2017-01-31T14:32:46Z

Sorry, what I meant was that my latest changes on that branch broke something in base, which I'll have to investigate. I did already rebase the new ColorTypes on top of the changes in base (but haven't pushed that yet).

timholy · 2017-01-31T14:33:49Z

OK, just ping here when all is set (I am too swamped to follow what's happening with the type-system stuff).

SimonDanisch · 2017-01-31T18:38:00Z

just to better track the progress here, this is the PR we are waiting for:
JuliaLang/julia#20006

juliohm · 2017-02-08T04:00:58Z

It looks like the PR was merged, this means that the issue is solved in master?

tlnagy · 2017-02-08T05:53:38Z

i think we're still waiting for #69 to merge

On Tue, Feb 7, 2017, at 20:00, Júlio Hoffimann wrote: It looks like the PR was merged, this means that the issue is solved in master? — You are receiving this because you commented. Reply to this email directly, view it on GitHub[1], or mute the thread[2].

Links: 1. #65 (comment) 2. https://github.com/notifications/unsubscribe-auth/ABlaL10ECo-NqQ6TLH7BYh_fZoPNlojHks5raT36gaJpZM4LlLN-

timholy · 2017-02-09T14:19:43Z

Closed by #68 and #69.

timholy mentioned this issue Jan 20, 2017

Save up memory in hausdorff distance JuliaImages/Images.jl#575

Merged

timholy mentioned this issue Jan 21, 2017

v0.6 precompile error: no method matching subtypes #66

Closed

cormullion mentioned this issue Jan 29, 2017

Add Images 0.6 upper bound on ColorSchemes, ImageQuilting, VideoIO JuliaLang/METADATA.jl#7737

Merged

Keno mentioned this issue Feb 1, 2017

WIP: 0.6 Compatibility #68

Closed

timholy closed this as completed Feb 9, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v0.6 precompile error: new UnionAll type breaks things #65

v0.6 precompile error: new UnionAll type breaks things #65

ghost commented Jan 17, 2017

ghost commented Jan 17, 2017

ghost commented Jan 17, 2017

JeffBezanson commented Jan 17, 2017

timholy commented Jan 17, 2017

Keno commented Jan 17, 2017

Keno commented Jan 17, 2017

Keno commented Jan 17, 2017

timholy commented Jan 17, 2017

tlnagy commented Jan 21, 2017

juliohm commented Jan 23, 2017

SimonDanisch commented Jan 23, 2017

Keno commented Jan 24, 2017

timholy commented Jan 24, 2017

Keno commented Jan 24, 2017

lobingera commented Jan 31, 2017

timholy commented Jan 31, 2017

Keno commented Jan 31, 2017

timholy commented Jan 31, 2017

Keno commented Jan 31, 2017

timholy commented Jan 31, 2017

SimonDanisch commented Jan 31, 2017

juliohm commented Feb 8, 2017

tlnagy commented Feb 8, 2017 via email

timholy commented Feb 9, 2017

v0.6 precompile error: new UnionAll type breaks things #65

v0.6 precompile error: new UnionAll type breaks things #65

Comments

ghost commented Jan 17, 2017

ghost commented Jan 17, 2017

ghost commented Jan 17, 2017

JeffBezanson commented Jan 17, 2017

timholy commented Jan 17, 2017

Keno commented Jan 17, 2017

Keno commented Jan 17, 2017

Keno commented Jan 17, 2017

timholy commented Jan 17, 2017

tlnagy commented Jan 21, 2017

juliohm commented Jan 23, 2017

SimonDanisch commented Jan 23, 2017

Keno commented Jan 24, 2017

timholy commented Jan 24, 2017

Keno commented Jan 24, 2017

lobingera commented Jan 31, 2017

timholy commented Jan 31, 2017

Keno commented Jan 31, 2017

timholy commented Jan 31, 2017

Keno commented Jan 31, 2017

timholy commented Jan 31, 2017

SimonDanisch commented Jan 31, 2017

juliohm commented Feb 8, 2017

tlnagy commented Feb 8, 2017 via email

timholy commented Feb 9, 2017