Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organization for v0.13 release #299

Open
kimikage opened this issue Apr 23, 2024 · 16 comments
Open

Re-organization for v0.13 release #299

kimikage opened this issue Apr 23, 2024 · 16 comments
Milestone

Comments

@kimikage
Copy link
Collaborator

kimikage commented Apr 23, 2024

We have followed a policy of "moving forward first" and minimizing backports. But I stopped, and the confusion has arisen.
So, I will try to backport some of the reverted PRs to minimize the gap between v0.11 and v0.12.
Some of those backports should result in incompatibilities.
The purpose is to encourage downstream packages to fix "unsafe" implementations, tests, etc.

Summary v0.11 v0.12 Note
🩹Update README.md 🪹⏪ #253
🩹Improve compN 🪹⏪ #245
💥Simplify display 🛡 #206
💥(Re-)define one 🛡 #243
💥Support alpha(::Number) 🛡 #177 Backportable but risky
✨Sampler-based Random 🪹⏪ #222 cf.#276
💥gamutmin/gamutmax 🛡 #254 Trivial but confusing
💥AbstractGray->abst. type 🛡 #252
🩹Conversions from/to Real 🪹⏪ #255
🩹Modify error messages 🪹⏪ #256
🩹Remove eltype_ub 🪹⏪ #258
💥Redesign constructors 🛡 #197 Follow-up needed
✨Add component iterator 🪹⏪ #260 Beware of Tuple(c)
✨Add init for reducec 🪹⏪ #263 Should rewrite !!! compat
🩹Conv. in the same color 🪹⏪ #264 Needs #260
🩹Simplify 0-arg ctor 🪹⏪ #265
✨Support isequal #279 #272 Backported
💥0.12.0-dev 🛡 #281
✨3-colorant mapc #282 🪹 Should be ported (with #260)
🐞Gray{T} constructor 🛡 #278 Should be generalize
✨Gray{Bool} rand 🪹 #276
🐞disable precompilation #270 #270 Needs review for new julia
🩹Update TagBot.yml #296 142353d Backported
✨Add Oklab and Oklch #296 #291 Backported
🩹Remove reinterpret test (296) #290 Backported (in #296)
🩹Patch tests for v0.11 #296 🪹 Should be ported! 😡
✨StyledStrings.SimpleColor 🪹 #293 Backportable (Needs #302,#307)
🩹Mention YUV 🪹 #297
🩹Update workflows #303 #301 Not required but helpful
🩹Followup StyledStringsExt 🪹 #302 Backportable (Needs #307)
🩹Fix unstable rand test 🪹 #305
🩹Update macOS test targets 🪹 #306 No need to backport
🩹Remove ones broken test 🛡 #308 for v0.12 (#243, #177)
🩹registered StyledStrings 🪹 #307 Backportable
🩹julia-actions/cache v2 🪹 #309 No need to backport

💥:Breaking change, ⏪: Reverted, 🪹: No implementation, 🛡: Should be blocked

@kimikage
Copy link
Collaborator Author

kimikage commented Apr 23, 2024

BTW, why not make PR mandatory (except in emergency situations)?

Also, before release, we should make sure that at least the Colors.jl test passes.

@kimikage
Copy link
Collaborator Author

The Tuple() constructor in PR #260 is debatable, but since there has actually been no opposition to it for three years.
So, I see no problem with its inclusion in v0.11 as a non-public method. Of course, it is not recommended to be used in downstream packages

@kimikage kimikage added this to the 0.12 milestone Apr 23, 2024
@kimikage
Copy link
Collaborator Author

I think it is safe to do this step-by-step, basically in a timeline, although we could put together several PRs.

@kimikage
Copy link
Collaborator Author

PR #302 makes StyledStringsExt technically backportable to v0.11.
However, as StyledStrings is currently unregistered, there is no guarantee that StyledStringsExt will actually work on Julia v1.9 or v1.10.
Also, StyledStringsExt can be substituted with a monkey patch.
For these reasons, I do not think that the backporting should be done.

@tecosaur
Copy link
Contributor

tecosaur commented May 6, 2024

The comment above in addition to #293 (comment) should likely be updated in light of recent changes, c.f. #293 (comment).

@kimikage
Copy link
Collaborator Author

kimikage commented May 6, 2024

Shouldn't we merge PR #307 first?

@tecosaur
Copy link
Contributor

tecosaur commented May 6, 2024

Before what? I'm just prompting that the description of the state of affairs needs updating.

@kimikage
Copy link
Collaborator Author

kimikage commented May 6, 2024

The decision to label or unlabel should be based not only on whether it is factually true, but also on whether it is in the public interest. I will update the status.

@ViralBShah
Copy link
Contributor

ViralBShah commented Oct 17, 2024

@kimikage Trying to see if we can remove the deprecated bindings and get a v0.12 released. Would you have time to help get it through? I hope you don't mind some of the recent changes I made to reduce CI running time. Happy to revert anything that you may not like.

The main reason a quick 0.12 release would help is to fix the deprecation warnings that show up across the ecosystem. Perhaps much of the reorganization you are discussing here could be considered for a future 0.13 release.

@ViralBShah
Copy link
Contributor

@kimikage I also just noticed your status that says you are under medical care. I hope your health is better and certainly do not mean to pull you into a bunch of PRs at a time you may need to focus on your health.

@johnnychen94
Copy link
Member

Thanks for restarting the upgrading conversation.

FWIW, I could perhaps help upgrade the ecosystem in December. Right now, it's just too much work in the company :( that have absolutely zero bandwidth to proceed with this.

@ViralBShah
Copy link
Contributor

ViralBShah commented Oct 20, 2024

Thank you @johnnychen94 for reviewing and chiming in. I am releasing 0.12 right now, and will update this issue on major work to 0.13. Hopefully the ecosystem is in a better maintained condition when you are able to find some time!

@ViralBShah ViralBShah changed the title Re-organization for v0.12 release Re-organization for v0.13 release Oct 20, 2024
@ViralBShah ViralBShah modified the milestones: 0.12, 0.13 Oct 20, 2024
@timholy
Copy link
Member

timholy commented Oct 21, 2024

Thanks for all this work, @ViralBShah. I haven't tested this but starting this week I will have some time. Let me know how I can help.

More globally, I'm also hoping to be able to return to pushing JuliaImages forward. The most urgent step, in my mind, is to switch to a mono-repo. That's not a small project, unfortunately. But 🤞 we may have some JuliaImages-development funding coming (I submitted a NASA proposal and it was approved for funding, with uncertain timeline), and if that happens I can delegate my lab programmer to do a lot of the heavy lifting.

@ViralBShah
Copy link
Contributor

Thanks @timholy. That would be awesome! I have been generally trying to maintain a few packages and push them along in my free time, and seeing where we can find new maintainers etc.

The deprecation warning makes people think that the package is not maintained, and I given @dgleich's efforts, I felt it was a good opportunity to get rid of it and tag everything.

I believe @ChrisRackauckas is working towards better tooling for monorepo of packages kind of thing. It would be good to check with what they are doing in SciML before starting the refactor.

@ViralBShah
Copy link
Contributor

The 0.13 milestone only has one issue remaining - #257. So much of what was planned for 0.12 is in the tagged release.

@ChrisRackauckas
Copy link

JuliaLang/julia#55516 @KristofferC is the one driving it from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants