fix(kernel): prevent setjmp
/longjmp
miscompilations through call_with_setjmp
#195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a safer wrapper for
setjmp
calledcall_with_setjmp
that helps to prevent LLVM miscompilations such as happened here where LLVM emitted a store immediate 1 instead of a load-add-store sequence for this code snippet:(see on godbolt here)
If you force
c
into a different stack frame or into a static things are fine btw if you were curious (see thesetjmp_longjmp_simple
test for more).The proper solution though - documented here and adapted into a crate https://github.com/pnkfelix/cee-scape - is to use inline assembly and mark all registers as clobbered along with preventing accidental misuse of the
JmpBuf
in invalid contexts.