Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
loader
andkernel
actually use the newBuddyAllocator
for frame allocation. This has a number of benefits:BumpAllocator
andBitMapAllocator
can only guarantee 4kib alignments and adding support for aligned regions would be difficult, wasteful or both. Since the whole spiel ofBuddyAllocator
is its support for power-of-two alignments, allocating regions with a specific alignment is trivial. The newNonContiguousFrames
implementation even allows for non-contiguous but still well aligned allocations of frames.BumpAllocator
was more than lackluster: With a single offset you simply can't bump-allocate properly from multiple regions. And even with multiple pointers, you end up with wasteful inefficient allocations when requesting large chunks such as for the kernel heap.