Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: support upload of data objects #37

Open
ncullen93 opened this issue Sep 25, 2022 · 1 comment
Open

Enhancement: support upload of data objects #37

ncullen93 opened this issue Sep 25, 2022 · 1 comment

Comments

@ncullen93
Copy link

ncullen93 commented Sep 25, 2022

Currently seems like only files can be uploaded since 'data_url' is passed to the uploadString function from firebase SDK. This could be handled by using uploadBytes or by setting the file type argument to 'base64' instead of 'data_url'. The major question here would be how to best convert a dataframe to a bytestring... guessing that's not so hard.

Reference: https://firebase.google.com/docs/storage/web/upload-files

My current solution is to just write the data to a temp file before upload and then delete it afterwards, but that's not ideal. I may tackle this and submit a pr if it really becomes an issue.

@JohnCoene
Copy link
Owner

Yes, that should be added. Sorry, I'm a bit overwhelmed with work at the moment and have little time for OSS, happy to look at a PR thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants