Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - Firestore #25

Open
fsty opened this issue Mar 7, 2022 · 8 comments
Open

Feature request - Firestore #25

fsty opened this issue Mar 7, 2022 · 8 comments
Assignees
Labels
feature New feature

Comments

@fsty
Copy link

fsty commented Mar 7, 2022

Hello!
There is any plan to add support for Firestore database ?

@JohnCoene
Copy link
Owner

Sorry, only just saw this. The support for Firestore is difficult to integrate with R given how it works. I tried, it's not impossible but makes for a very ugly API

@munoztd0 munoztd0 self-assigned this Jun 30, 2023
@munoztd0 munoztd0 added the feature New feature label Jun 30, 2023
@udurraniAtPresage
Copy link

Sorry, only just saw this. The support for Firestore is difficult to integrate with R given how it works. I tried, it's not impossible but makes for a very ugly API

It would be awesome if firestore feature is available even with an ugly API. Thanks for your package.

@emillykkejensen
Copy link

Have you thought about integrating something like this:
https://gabrielcp.medium.com/introduction-to-working-with-firestore-in-r-99443489b01b ?

@durraniu
Copy link

durraniu commented Nov 3, 2023

Have you thought about integrating something like this: https://gabrielcp.medium.com/introduction-to-working-with-firestore-in-r-99443489b01b ?

Yes, I have used the functions from that post and also wrote my own for query filtering. It would be awesome if {firebase} also has these available.

@JohnCoene
Copy link
Owner

The issue is not technical but how we manage to nicely wrap the query API.

We cannot do HTTP requests, {firebase} is all based on the official JavaScript SDK's and I think it should remain like this.

If you anyone has anything to propose in that regard it is more than welcome,

e.g.: take a look at this, I think it shows some of the complexities I hint at.

We need an R API not just around R/shiny (sendCustomMessage) we need to map the firestore ORM in R, and that's a lot of work I'm not sure where to start.

@udurraniAtPresage
Copy link

I understand. I'd love to contribute but I have little to no experience with JavaScript.

I guess the best way to go is to use the Cloud Firestore REST API using {httr} as I am doing now.

Thank you for your thorough response.

@JohnCoene
Copy link
Owner

Initial work on firestore support on a new branch

remotes::install_github("JohnCoene/firebase@firestore")

See this document if you want to try

@JohnCoene JohnCoene changed the title Feature request Feature request - Firestore May 20, 2024
@durraniu
Copy link

This is really cool, thanks @JohnCoene.

I understand that {firebase} won't use HTTP requests. So, if anyone else is interested, I authored this package based on Firestore REST API: https://github.com/Presage-Group/frstore

But {firebase} native solution for Firestore will be awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

No branches or pull requests

6 participants