-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config option to enable or disable AUR completions #539
Conversation
Cache files are split into aur_*.cache and repo_*.cache in preperation for a new config option to disable AUR completion.
Adds the new confg option "completeaur" with corresponding cmd flags. Defaults to 'true' to maintain existing behavior when not set.
Instead of a config option how about making the completion respect --aur/--repo? No idea how hard that is to implement though. |
Could do that, but the config would just have to move to the completion scripts. Not quite sure how that should work, an env var maybe? I could probably update zsh, but I'm not familiar with bash or fish completion. |
@ipha I wouldn't separate into 2 files. We already have a good file for repo, it's the database. We just add it to aur_fish.cache because it's convenient. To alleviate network side pains I propose the following:
If it's not network sided, I suppose you're using bash which is painfully slow when it comes to completions, that has no cure unfortunately. @Morganamilo It's a pain on the completion side but doable and easy on the yay side. Making it respect that makes more sense |
So it's zsh, better but not perfect when it comes to large completion file indexing. This option if added only for the "clutter" aspect wouldn't need to be added for
|
Any sort of network action on completion will have a noticeable delay -- even with a short timeout. How do propose I proceed if I want a feature that just turns off aur completions? |
The way I see it, the point of Yay is to add AUR support, if you're only interested in repo packages whats wrong with pacman? |
I agree with this issue. Autocompletion is delayed and the ability to disable AUR completion could be useful. @Morganamilo Yes, AUR helpers are used to use AUR. But some people (me as an example) are using AUR-helper's command instead |
Hopefully #584 is good enough for you. The network delay should be gone at least. If not you canforce it away by setting |
Personally, I find the initial delay when it's building the cache annoying and the extra clutter makes it harder to find the repo package I'm looking for. So let's add an option to disable it!
Two parts to this pull request: