Improve quality

Javacym · Sep 9, 2015 · 1d99d78 · 1d99d78
1 parent 49ef17c
commit 1d99d78
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/sonar-batch/src/main/java/org/sonar/batch/analysis/package-info.java b/sonar-batch/src/main/java/org/sonar/batch/analysis/package-info.java
@@ -20,4 +20,4 @@
 @ParametersAreNonnullByDefault
 package org.sonar.batch.analysis;
 
-import javax.annotation.ParametersAreNonnullByDefault;
+import javax.annotation.ParametersAreNonnullByDefault;
diff --git a/sonar-home/src/test/java/org/sonar/home/cache/FileHashesTest.java b/sonar-home/src/test/java/org/sonar/home/cache/FileHashesTest.java
@@ -33,6 +33,8 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.math.BigInteger;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
 import java.security.SecureRandom;
 
 import static org.assertj.core.api.Assertions.assertThat;
@@ -60,10 +62,17 @@ public void test_md5_hash() {
       String random = randomString();
       assertThat(hash(random)).as(random).isEqualTo(
         DigestUtils.md5Hex(random).toLowerCase()
-      );
+        );
     }
   }
 
+  @Test
+  public void test_hash_file() throws IOException {
+    File f = temp.newFile();
+    Files.write(f.toPath(), "sonar".getBytes(StandardCharsets.UTF_8));
+    assertThat(hashFile(f)).isEqualTo("d85e336d61f5344395c42126fac239bc");
+  }
+
   @Test
   public void test_toHex() {
     // lower-case
@@ -74,7 +83,7 @@ public void test_toHex() {
       String random = randomString();
       assertThat(FileHashes.toHex(random.getBytes())).as(random).isEqualTo(
         Hex.encodeHexString(random.getBytes()).toLowerCase()
-      );
+        );
     }
   }
 
@@ -86,7 +95,6 @@ public void fail_if_file_does_not_exist() throws IOException {
     thrown.expect(IllegalStateException.class);
     thrown.expectMessage("Fail to compute hash of: " + file.getAbsolutePath());
 
-
     new FileHashes().of(file);
   }
 
@@ -112,4 +120,8 @@ private String hash(String s) {
       IOUtils.closeQuietly(in);
     }
   }
+
+  private String hashFile(File f) {
+    return new FileHashes().of(f);
+  }
 }