fix: < > <= >= on aliases to comparable types return boolean

Fixes teal-language#844.
JR-Mitchell · Nov 16, 2024 · f9c6d3d · f9c6d3d
1 parent be8ac11
commit f9c6d3d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/spec/lang/operator/lt_spec.lua b/spec/lang/operator/lt_spec.lua
@@ -30,4 +30,12 @@ describe("<", function()
    ]], {
       { msg = "cannot use operator '<' for types boolean and integer" }
    }))
+
+   it("< on aliases to comparable types return boolean", util.check([[
+      local type Test = integer
+
+      local function f(a: Test, b: Test) : boolean
+         return a < b
+      end
+   ]]))
 end)
diff --git a/tl.lua b/tl.lua
@@ -12623,7 +12623,7 @@ self:expand_type(node, values, elements) })
                   end
                end
 
-               if ua.typename == "nominal" and ub.typename == "nominal" and not meta_on_operator then
+               if (not t) and ua.typename == "nominal" and ub.typename == "nominal" and not meta_on_operator then
                   if self:is_a(ua, ub) then
                      t = ua
                   else

diff --git a/tl.tl b/tl.tl
@@ -12623,7 +12623,7 @@ do
                   end
                end
 
-               if ua is NominalType and ub is NominalType and not meta_on_operator then
+               if (not t) and ua is NominalType and ub is NominalType and not meta_on_operator then
                   if self:is_a(ua, ub) then
                      t = ua
                   else
-Original file line number
+Diff line change
@@ Expand Up / @@ -12623,7 +12623,7 @@ self:expand_type(node, values, elements) }) @@
                       end
                    end
-                   if ua.typename == "nominal" and ub.typename == "nominal" and not meta_on_operator then
+                   if (not t) and ua.typename == "nominal" and ub.typename == "nominal" and not meta_on_operator then
                       if self:is_a(ua, ub) then
                          t = ua
                       else
@@ Expand Down @@