add test to catch content based etags

JJ11teen · May 16, 2021 · d6596cc · d6596cc
1 parent 9e2ca86
commit d6596cc
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/tests/tests/1_storageproviders.py b/tests/tests/1_storageproviders.py
@@ -61,3 +61,11 @@ def test_etags_are_enforced(self, storage_provider: StorageProvider, test_id: st
             storage_provider.upload_data(key, "bad-etag", b"data")
         with pytest.raises(KeySyncError):
             storage_provider.delete_data(key, "bad-etag")
+
+    def test_etags_change_with_same_data(self, storage_provider: StorageProvider, test_id: str):
+        key = test_id + "etags-unique-same-data-test"
+
+        first_etag = storage_provider.upload_data(key, None, b"static-data")
+        second_etag = storage_provider.upload_data(key, first_etag, b"static-data")
+
+        assert first_etag != second_etag
diff --git a/tests/tests/3_multiplecloudmapping.py b/tests/tests/3_multiplecloudmapping.py
@@ -25,7 +25,7 @@ def test_no_ownership_error(self, storage_provider: StorageProvider, test_id: st
         sess_3 = CloudMapping(storageprovider=storage_provider)
         # Session 1 updates the key:
         sess_1[key] = b"session_1"
-        # Session 3 is knows the key exists, so KeySyncError on get, set and delete:
+        # Session 3 knows the key exists, but is out of sync so KeySyncError on get, set and delete:
         with pytest.raises(KeySyncError):
             sess_3[key]
         with pytest.raises(KeySyncError):