Skip to content

Commit

Permalink
Remove PopupBaseView::container_view().
Browse files Browse the repository at this point in the history
This method is not actually used - the two callers that could use it
just call delegate_->container_view() directly.

Bug: n/a
Change-Id: I8cbdb6f2f12760f1153036a7ed49f2d7bde016f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526245
Auto-Submit: Jan Keitel <jkeitel@google.com>
Commit-Queue: Bruno Braga <brunobraga@google.com>
Commit-Queue: Jan Keitel <jkeitel@google.com>
Reviewed-by: Bruno Braga <brunobraga@google.com>
Cr-Commit-Position: refs/heads/main@{#1299163}
  • Loading branch information
Jan Keitel authored and Chromium LUCI CQ committed May 10, 2024
1 parent fc35df1 commit c43cb85
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
4 changes: 0 additions & 4 deletions chrome/browser/ui/views/autofill/popup/popup_base_view.cc
Original file line number Diff line number Diff line change
Expand Up @@ -578,10 +578,6 @@ content::WebContents* PopupBaseView::GetWebContents() const {
return delegate_->GetWebContents();
}

gfx::NativeView PopupBaseView::container_view() {
return delegate_->container_view();
}

BEGIN_METADATA(PopupBaseView)
ADD_READONLY_PROPERTY_METADATA(gfx::Rect, ContentAreaBounds)
END_METADATA
Expand Down
3 changes: 0 additions & 3 deletions chrome/browser/ui/views/autofill/popup/popup_base_view.h
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,6 @@ class PopupBaseView : public PopupRowView::AccessibilitySelectionDelegate,
// Return the web contents related to this.
content::WebContents* GetWebContents() const;

// Must return the container view for this popup.
gfx::NativeView container_view();

// Scoped observation for focus events.
base::ScopedObservation<views::WidgetFocusManager,
views::WidgetFocusChangeListener>
Expand Down

0 comments on commit c43cb85

Please sign in to comment.