Skip to content

Commit

Permalink
Enable clang-tidy argument hint check (bugprone-argument-comment).
Browse files Browse the repository at this point in the history
Following this discussion on cxx [1], this CL enables the
bugprone-argument-comment check in Tricium.

[1] https://groups.google.com/a/chromium.org/g/cxx/c/LysF5a-aUDo

Change-Id: I5d81b27bcdc6b2e84c772ddbece7df6eeb86f4e7
Bug: 1016926
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557940
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Auto-Submit: Tal Pressman <talp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832257}
  • Loading branch information
talpr authored and Chromium LUCI CQ committed Dec 1, 2020
1 parent a9b42f2 commit 89a0e82
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .clang-tidy
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
---
Checks: '-*,
bugprone-argument-comment,
bugprone-string-integer-assignment,
bugprone-unused-raii,
bugprone-use-after-move,
Expand Down Expand Up @@ -32,4 +33,3 @@
- key: modernize-use-emplace.IgnoreImplicitConstructors
value: 1
...

1 change: 1 addition & 0 deletions base/win/.clang-tidy
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
---
Checks: '-*,
bugprone-argument-comment,
google-build-namespaces,
google-readability-namespace-comments,
modernize-avoid-bind,
Expand Down

0 comments on commit 89a0e82

Please sign in to comment.