Skip to content

Commit

Permalink
Update docs about code coverage on full Chromium
Browse files Browse the repository at this point in the history
Running full Chromium with code coverage no longer requires disabling
the sandbox. It was fixed in 2019.

Found while working on crbug.com/1399354

Bug: None, 972232
No-Try: True
Change-Id: Ieeb86f162ebc0f955ace8d511ee3bf7c9b61cf92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4129804
Reviewed-by: Zhaoyang Li <zhaoyangli@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1089024}
  • Loading branch information
kainino0x authored and Chromium LUCI CQ committed Jan 4, 2023
1 parent 51ec881 commit 6f537eb
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions docs/testing/code_coverage.md
Original file line number Diff line number Diff line change
Expand Up @@ -284,10 +284,9 @@ Yes, with some important caveats. It is possible to build `chrome` target with
code coverage instrumentation enabled. However, there are some inconveniences
involved:

* Linking may take a while
* The binary is huge (~4GB)
* The browser "works", but is noticeably slow and laggy
* The sandbox needs to be disabled (`--no-sandbox`)
* Linking may take a while, especially if you use a non-component build.
* The binary is huge (2-4GB).
* The browser may be noticeably slow and laggy.

For more information, please see [crbug.com/834781].

Expand Down

0 comments on commit 6f537eb

Please sign in to comment.