Rename some conformance tests correctly #6659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwxm
added
Test
Builtins
No Changelog Required
Unisay
approved these changes
Nov 13, 2024
kwxm
changed the title
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the files in the coformance tests were renamed in #6627 but I got it wrong for
bls12_381_G1_scalarMul/mul-neg-one(I renamed the direcrory but forgot to rename its contents) . This should fix that.I see now that if you have a directory called
test-123and it containstest456.uplcthe conformance test will generate golden files calledtest-123.uplc.expectedandtest-123.uplc.budget.expected. It does check that there's only one.uplcfile in the directory but doesn't check that the name of the file matches the name of the directory and bases the names of the golden files on the name of the directory. I'll open an issue to fix that.