Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Builtins] Drop 'RuntimeScheme' #4778

Merged
merged 20 commits into from
Aug 24, 2022
Merged

[Builtins] Drop 'RuntimeScheme' #4778

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
2ea0b5c
[Builtins] Drop 'RuntimeScheme'
effectfully Jul 20, 2022
86a3e24
Revert 'Eliminate 'fun' from 'VBuiltin''
effectfully Jul 22, 2022
f5639db
Docs and polishing
effectfully Aug 2, 2022
c736ebf
Back to 'ExMemoryUsage' in 'HasMeaningIn'
effectfully Aug 3, 2022
4c001d3
Fixing tests and renaming
effectfully Aug 3, 2022
39784e3
Remove accidental superficial changes
effectfully Aug 3, 2022
eb3467d
Fix some leftovers
effectfully Aug 3, 2022
9f6211f
Merge branch 'master' of https://github.com/input-output-hk/plutus in…
effectfully Aug 10, 2022
2475d51
Add Note [ExMemoryUsage instances for non-constants]
effectfully Aug 11, 2022
fbc32ec
Doc tweaking
effectfully Aug 11, 2022
dc35696
Add some docs to 'CostingFun.Core'
effectfully Aug 11, 2022
e16a7d0
Tweaking
effectfully Aug 11, 2022
f8420c0
Add Note [Merging the denotation and the costing function]
effectfully Aug 11, 2022
404df06
Tweaking
effectfully Aug 11, 2022
150c935
Update plutus-core/plutus-core/src/PlutusCore/Builtin/Meaning.hs
effectfully Aug 16, 2022
0975598
Update plutus-core/plutus-core/src/PlutusCore/Builtin/Meaning.hs
effectfully Aug 16, 2022
b0c515f
Minor tweaks
effectfully Aug 16, 2022
5866296
More readable 'toMonoImmediateF' implementations
effectfully Aug 16, 2022
5ada64f
A comment on caching of 'BuiltinRuntime's
effectfully Aug 16, 2022
369df92
Rename the constructors of 'BuiltinRuntime'
effectfully Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update plutus-core/plutus-core/src/PlutusCore/Builtin/Meaning.hs 
Co-authored-by: Michael Peyton Jones <michael.peyton-jones@iohk.io>
  • Loading branch information
@effectfully @michaelpj
effectfully and michaelpj authored Aug 16, 2022
commit 150c935405ac1c3abaf6d5caa97c5cf396bc1de1
2 changes: 1 addition & 1 deletion plutus-core/plutus-core/src/PlutusCore/Builtin/Meaning.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ of the denotation and the costing function. This is because:

1. the two are fundamentally distinct and we have loads of documentation for each of them
separately, so conflating them in the actual API would be unnecessary coupling
2. right now it's clear which bits of the definition of a builtin consitute evaluation and which
2. right now it's clear which bits of the definition of a builtin constitute evaluation and which
ones constitute costing as the two are different arguments to 'makeBuiltinMeaning'. If evaluation
and costing were intertwined, it would be much harder to review the definition of a builtin
3. ... and it would also be more boilerplate and less clear type signatures
Expand Down