Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Builtins] No-legacy unlifting #4510

Closed
wants to merge 11 commits into from
Closed

[Builtins] No-legacy unlifting #4510

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c1030cc
[Builtins] Defer 'readKnown' until full saturation
effectfully Feb 26, 2022
ae0a821
Use 'UnliftWhenSaturated' instead of 'UnliftImmediately'
effectfully Mar 2, 2022
4388d6c
Revert "Use 'UnliftWhenSaturated' instead of 'UnliftImmediately'"
effectfully Mar 2, 2022
932756a
Correct causes for unlifting errors
effectfully Mar 9, 2022
6c9a09a
Use 'UnliftWhenSaturated' instead of 'UnliftImmediately'
effectfully Mar 9, 2022
f4a237c
Playing with bangs
effectfully Mar 9, 2022
e3073ec
Remove a bang
effectfully Mar 9, 2022
046cf60
Merge branch 'master' of https://github.com/input-output-hk/plutus in…
effectfully Mar 28, 2022
b6743db
Parallel 'TypeScheme' and 'RuntimeScheme'
effectfully Mar 30, 2022
5d3fb5a
Drop immediate unlifting
effectfully Mar 30, 2022
718499a
Drop redundant laziness annotations
effectfully Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Use 'UnliftWhenSaturated' instead of 'UnliftImmediately'" 
This reverts commit 19656b6.
  • Loading branch information
@effectfully
effectfully committed Mar 21, 2022
commit 4388d6c64c5784d06d9c9e3acf2e27ee017f7ccf
2 changes: 1 addition & 1 deletion plutus-core/plutus-core/src/PlutusCore/Builtin/Runtime.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ data UnliftMode
| UnliftWhenSaturated

unliftMode :: UnliftMode
unliftMode = UnliftWhenSaturated
unliftMode = UnliftImmediately

-- | Instantiate a 'BuiltinMeaning' given denotations of built-in functions and a cost model.
toBuiltinRuntime :: cost -> BuiltinMeaning val cost -> BuiltinRuntime val
Expand Down
8 changes: 4 additions & 4 deletions plutus-core/untyped-plutus-core/test/Evaluation/Golden/iteAtIntegerWrongCondType.plc.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
(Right [
[ (force (builtin ifThenElse)) (con string "11 <= 22") ]
(con string "\172(11 <= 22)")
])
(Left An error has occurred: error:
Could not unlift a builtin:
Type mismatch: expected: bool; actual: string
Caused by: [ (force (builtin ifThenElse)) (con string "11 <= 22") ])
8 changes: 4 additions & 4 deletions plutus-core/untyped-plutus-core/test/Evaluation/Golden/iteAtIntegerWrongCondType.uplc.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
(Right [
[ (force (builtin ifThenElse)) (con string "11 <= 22") ]
(con string "\172(11 <= 22)")
])
(Left An error has occurred: error:
Could not unlift a builtin:
Type mismatch: expected: bool; actual: string
Caused by: [ (force (builtin ifThenElse)) (con string "11 <= 22") ])