Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] [Builtins] Add Note [How to add a built-in function: complicated cases] #4454

Merged
merged 1 commit into from
Mar 7, 2022
Merged

[Docs] [Builtins] Add Note [How to add a built-in function: complicated cases] #4454

merged 1 commit into from
Mar 7, 2022

Conversation

effectfully
Copy link
Contributor

Another piece of docs. Some stuff still remains to be written, that's for another time.

@effectfully effectfully requested review from michaelpj and kwxm March 6, 2022 17:25
@effectfully effectfully mentioned this pull request Mar 6, 2022
Open
michaelpj
michaelpj approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@michaelpj michaelpj merged commit e282d40 into master Mar 7, 2022
kwxm
kwxm reviewed Mar 8, 2022
View reviewed changes
Copy link
Contributor

@kwxm kwxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's very helpful: thanks!

An extremely meta (and maybe nonsensical) question occurs to me. Perhaps unfairly, I view a lot of what's going on here as clever tricks exploiting weird corners of the Haskell type system. I wonder if it would be possible to invent some extension to the type system that would make it easier to support this kind of thing. I have no idea what that could possibly involve though!

@kwxm kwxm mentioned this pull request Mar 8, 2022
Closed
@effectfully effectfully deleted the effectfully/docs/builtins/built-in-function-complicated-cases branch March 8, 2022 20:27
@effectfully
Copy link
Contributor Author

@kwxm

An extremely meta (and maybe nonsensical) question occurs to me. Perhaps unfairly, I view a lot of what's going on here as clever tricks exploiting weird corners of the Haskell type system. I wonder if it would be possible to invent some extension to the type system that would make it easier to support this kind of thing. I have no idea what that could possibly involve though!

Interesting. Documented that.

@effectfully effectfully changed the title [Docs] Add Note [How to add a built-in function: complicated cases] [Docs] [Builtins] Add Note [How to add a built-in function: complicated cases] Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwxm kwxm kwxm left review comments

@michaelpj michaelpj michaelpj approved these changes

Assignees
No one assigned
Labels
Builtins Documentation User experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@effectfully @michaelpj @kwxm