Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantiating builtin meanings on the fly instead of caching them (impressively bad results) #3317

Closed
wants to merge 3 commits into from
Closed

Instantiating builtin meanings on the fly instead of caching them (impressively bad results) #3317

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e44783
[Evaluation] Don't cache meanings of builtins
effectfully Jun 4, 2021
a3c99ba
Added the vital strictness
effectfully Jun 4, 2021
ecc2222
Revert "Added the vital strictness"
effectfully Jun 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added the vital strictness
  • Loading branch information
@effectfully
effectfully committed Jun 4, 2021
commit a3c99babbca57b0bb93e0851b08010975c826caf
6 changes: 3 additions & 3 deletions plutus-core/plutus-core/src/PlutusCore/Constant/Meaning.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ import Universe
-- functions from a certain set, hence the @cost@ parameter.
data BuiltinMeaning term cost =
forall args res. BuiltinMeaning
(TypeScheme term args res)
(FoldArgs args res)
(cost -> FoldArgsEx args)
!(TypeScheme term args res)
!(FoldArgs args res)
!(cost -> FoldArgsEx args)
-- I tried making it @(forall term. HasConstantIn uni term => TypeScheme term args res)@ instead of
-- @TypeScheme term args res@, but 'makeBuiltinMeaning' has to talk about
-- @KnownPolytype binds term args res a@ (note the @term@), because instances of 'KnownMonotype'
Expand Down