Gpu #411
Gpu #411
Conversation
There was a problem hiding this comment.
Nice to see the changes needed to include CUDA support aren't very big, and it can be included as another "platform" type, mainly changing lapack_wrap.cc. One thing we should discuss is the experience for users who are not going to opt into using CUDA. For example, will they be able to compile the code without having the Thrust library as a dependency? Also if the platform is set to enable the CUDA backend, does all the code now run on GPU or does it require that to still be turned on at runtime (I would prefer the second option).
| @@ -18,6 +18,7 @@ | |||
|
|
|||
| #include "itensor/util/print.h" | |||
| #include "itensor/util/stdx.h" | |||
| #include <thrust/device_vector.h> | |||
There was a problem hiding this comment.
Will this include make it remain possible for people to compile ITensor if they aren't going to use CUDA or thrust? Also I'm not familiar with thrust: is it related to GPU or something else?
itensor/types.h
Outdated
| @@ -28,18 +28,30 @@ | |||
| namespace itensor { | |||
|
|
|||
| using Real = double; | |||
| using Cplx = std::complex<double>; | |||
| using Complex = std::complex<double>; | |||
| /* | |||
There was a problem hiding this comment.
This comment block should be removed if not needed, thanks.
|
Thanks, this looks like an interesting PR but some aspects of it aren't obvious to me. Could you please describe the changes at a high level? Also I made some review comments above and in the code changes page. |
|
Hi @emstoudenmire, thanks for taking the time to look at the code. The PR was sent by mistake, we intended to do some more work on the local fork before showing you guys. We will mark it as a draft PR so that you know you shouldn't spend too much time looking at it. |
|
Thanks - sounds good. We can consider having additional dependencies such as Thrust but by default these should be turned off or not required if the CUDA backend is not being enabled. Also would be good to discuss whether the CUDA backend can be turned on as a runtime option or not in our further discussions. Looking forward - |
I've added a comment in options