Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostics tool for ill-posed constraints #1454

Merged
merged 62 commits into from
Nov 5, 2024
Merged

Diagnostics tool for ill-posed constraints #1454

Changes from 1 commit
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
37e0fae
Working on cancellation detection
Jul 22, 2024
1664593
Merge branch 'main' of https://github.com/IDAES/idaes-pse into cons_m…
Jul 22, 2024
4d48741
Fixing typo
Jul 22, 2024
a1e91d2
Merge branch 'main' of https://github.com/IDAES/idaes-pse into cons_m…
Aug 6, 2024
33a4435
Improving efficiency
Aug 6, 2024
747eb7d
More efficiency and testing
Aug 6, 2024
707de1e
Reducing duplicated code in tests
Aug 9, 2024
3a6400b
Finishing testing
Aug 9, 2024
c3e315c
Adding additioanl tests and clean up
Aug 9, 2024
2ab55ca
Running pylint
Aug 9, 2024
2af9478
Adding constraint walker to diagnostics toolbox
Aug 9, 2024
b9d12ea
Merge branch 'main' into cons_mag_diagnostics
Aug 23, 2024
162f631
Addressing simple review comments
Aug 23, 2024
90d2cd3
Accumulate node rather than str(node)
Aug 23, 2024
152b044
Clean up some tests
Aug 23, 2024
81c1835
Supporting ranged expressions
Aug 23, 2024
849647c
Merge branch 'main' into cons_mag_diagnostics
Aug 23, 2024
bff77d5
Apply suggestions from code review
andrewlee94 Aug 23, 2024
54e87c4
Merge branch 'main' of https://github.com/IDAES/idaes-pse into cons_m…
Aug 25, 2024
11d3f33
Merge branch 'cons_mag_diagnostics' of https://github.com/andrewlee94…
Aug 25, 2024
85d1956
Regorganising and fixing pylint issues
Aug 25, 2024
d486e85
Fixing false positives for linking constraints
Aug 25, 2024
1048b32
Fixing unused variable warning
Aug 25, 2024
d10a493
Fixing bug related to external functions with string arguments
Sep 6, 2024
00a3434
Merge branch 'main' of https://github.com/IDAES/idaes-pse into cons_m…
Sep 10, 2024
d27de22
Merge branch 'old_scaling_bug' into cons_mag_diagnostics
Sep 10, 2024
6d6fe2c
Addressing comments
Sep 10, 2024
9dbd521
Merge branch 'main' into cons_mag_diagnostics
Sep 11, 2024
678caf8
removing debugging prints
Sep 11, 2024
47a58f4
Merge branch 'main' of https://github.com/IDAES/idaes-pse into cons_m…
Sep 23, 2024
1b5d1d2
Addressing more comments
Sep 23, 2024
18a6ff1
Merge branch 'cons_mag_diagnostics' of https://github.com/andrewlee94…
Sep 23, 2024
ef2e228
Debugging issue with nested external functions
Sep 24, 2024
70636cb
Adding todo
Sep 24, 2024
5d5da12
Relax test tolerance due to Windows failures
Sep 24, 2024
c173984
Adding catches for string arguments/values
Sep 30, 2024
7c03467
Test for nested external functions
Sep 30, 2024
21cca53
Fixing bug in walker logic for string arguments to external funcitons
Oct 8, 2024
ad6dd99
Merge branch 'main' into cons_mag_diagnostics
Oct 9, 2024
a3cde35
Merge branch 'main' into cons_mag_diagnostics
Oct 25, 2024
ddc8fb8
Address double counting of constraints
Oct 25, 2024
bd331e8
Fixing typo
Oct 25, 2024
b3098e1
Bumping Pyomo version
Oct 25, 2024
60e71cb
Adding zero tolerance
Oct 25, 2024
aebb118
Adding test for zero tolerance
Oct 25, 2024
9956286
Fixing typo
Oct 28, 2024
8cf3bbe
Logic to skip scaled equality constraints
Oct 28, 2024
34a2b58
Merge branch 'main' into cons_mag_diagnostics_2
Oct 28, 2024
93ef9d8
Handling mole fraction type constraints
Oct 28, 2024
3284d3e
Merge branch 'main' into cons_mag_diagnostics
Oct 29, 2024
2d5ec93
Catching negations
Oct 29, 2024
5ffec52
Fixing typos
Oct 29, 2024
161b15b
Limit of cancelling combinations
Oct 30, 2024
7deb640
Fixing typos
Oct 30, 2024
86bd61c
Displaying cancelling terms to user
Oct 30, 2024
9b13cb1
More detail of mismatches
Oct 30, 2024
6577481
Adding hooks and warnings about new config arguments
Oct 30, 2024
94fe8c0
Expression aware to string method
Nov 1, 2024
360bb39
Moving expression writer to util/misc
Nov 1, 2024
1fb2743
Typos and comments
Nov 1, 2024
628f445
Using StrEnum
Nov 5, 2024
1a4a1ee
Merge branch 'main' into cons_mag_diagnostics
Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into cons_mag_diagnostics
  • Loading branch information
Andrew Lee committed Oct 29, 2024
commit 3284d3e0f78b860151c0df51bbdd2529f09c0b6c

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.