Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crossflow hx #1382

Merged
merged 46 commits into from
Apr 22, 2024
Merged
Changes from 2 commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
5782077
add unit models
dallan-keylogic Feb 21, 2024
db31552
edits
dallan-keylogic Feb 22, 2024
cde84b7
changes
dallan-keylogic Mar 8, 2024
1bc0ea7
Code cleaning
dallan-keylogic Mar 12, 2024
65b3863
Fix initialization
dallan-keylogic Mar 12, 2024
d9405f8
Begin adding tests
dallan-keylogic Mar 12, 2024
693305f
changes
dallan-keylogic Mar 12, 2024
a2fe413
test units
dallan-keylogic Mar 15, 2024
a30edf6
fix pressure drop unit issue
dallan-keylogic Mar 15, 2024
1c03d23
Moving towards heater testing
dallan-keylogic Mar 19, 2024
599ae34
move changes from other branch
dallan-keylogic Mar 20, 2024
5b6f6ce
Merge branch 'main' into crossflow_hx
dallan-keylogic Mar 20, 2024
50d5fd9
format remaining file
dallan-keylogic Mar 20, 2024
52e67b6
separate 1d hx changes
dallan-keylogic Mar 22, 2024
d08267d
Merge branch 'main' into crossflow_hx
dallan-keylogic Mar 22, 2024
c9b86da
Fix pylint errors
dallan-keylogic Mar 22, 2024
4a0f9aa
more pylint issues
dallan-keylogic Mar 22, 2024
e440cc5
remove elevation change
dallan-keylogic Apr 1, 2024
57d1e87
run black
dallan-keylogic Apr 1, 2024
659de32
get rid of commented code
dallan-keylogic Apr 3, 2024
44f0345
Merge branch 'main' into crossflow_hx
dallan-keylogic Apr 4, 2024
bcde9a3
Fix typo
dallan-keylogic Apr 4, 2024
f78413a
Merge branch 'nu_xflow' into crossflow_hx
dallan-keylogic Apr 4, 2024
09e6b31
Merge branch 'main' into crossflow_hx
dallan-keylogic Apr 4, 2024
37d3edf
At Andrew's insistence, make methods public
dallan-keylogic Apr 12, 2024
622762a
address more of Andrew's comments
dallan-keylogic Apr 12, 2024
eb1fc30
Merge branch 'main' into crossflow_hx
dallan-keylogic Apr 12, 2024
2514cfb
Update initialization to new form
dallan-keylogic Apr 15, 2024
c721eb5
documentation
dallan-keylogic Apr 16, 2024
04153e5
Documentation in progress
dallan-keylogic Apr 16, 2024
ff75476
Merge branch 'xflow_hx' into crossflow_hx
dallan-keylogic Apr 16, 2024
53c3849
remove debugging
dallan-keylogic Apr 16, 2024
e8068b7
Documentation
dallan-keylogic Apr 17, 2024
b2af3c9
pitch
dallan-keylogic Apr 18, 2024
4e6af02
Merge branch 'main' into crossflow_hx
dallan-keylogic Apr 18, 2024
ad4dddf
polishing step
dallan-keylogic Apr 18, 2024
74c5e73
run black
dallan-keylogic Apr 18, 2024
dd3afc7
new black version
dallan-keylogic Apr 18, 2024
ac64869
culling common
dallan-keylogic Apr 18, 2024
bf82efd
Docstrings and merges
dallan-keylogic Apr 19, 2024
3c34674
spelling
dallan-keylogic Apr 19, 2024
864695f
pylint
dallan-keylogic Apr 19, 2024
4ffcc52
more Andrew suggestions
dallan-keylogic Apr 22, 2024
10e46fa
run Black
dallan-keylogic Apr 22, 2024
18a7f36
pylint
dallan-keylogic Apr 22, 2024
29c4a88
no more values
dallan-keylogic Apr 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

These merge commits were added into this branch cleanly.

There are no new changes to show.