Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate methods in generic property packages #75

Open
andrewlee94 opened this issue May 1, 2020 · 0 comments
Open

Validate methods in generic property packages #75

andrewlee94 opened this issue May 1, 2020 · 0 comments
Assignees
@andrewlee94
Labels
enhancement New feature or request Priority:Low Low Priority Issue or PR

Comments

@andrewlee94
Copy link
Member

Currently, the generic property package framework does not validate the methods provided as configuration argument, i.e. a user could provide a method for cp as the method for enthalpy and no issue would be raised.

We should add some method for validating these so that if a method is used for something it wasn't designed for, the user will be informed.
@andrewlee94 andrewlee94 self-assigned this May 1, 2020
@andrewlee94 andrewlee94 changed the title Validate methods in generic proeprty packages Validate methods in generic property packages May 4, 2020
@andrewlee94 andrewlee94 transferred this issue from another repository Nov 10, 2020
@lbianchi-lbl lbianchi-lbl transferred this issue from another repository Nov 14, 2020
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Nov 14, 2020
@andrewlee94 andrewlee94 added enhancement New feature or request Priority:Low Low Priority Issue or PR and removed Priority:Normal Normal Priority Issue or PR labels Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewlee94 andrewlee94

Labels
enhancement New feature or request Priority:Low Low Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ksbeattie @andrewlee94