Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Combustion Gas Property Package #1186

Open
eslickj opened this issue May 16, 2023 · 1 comment
Open

Generic Combustion Gas Property Package #1186

eslickj opened this issue May 16, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request Priority:Low Low Priority Issue or PR

Comments

@eslickj
Copy link
Member

eslickj commented May 16, 2023

In the power generation section of extra models we have a flue gas and natural gas physical property and reaction packages. We should probably add a new generic combustion gas pyhsical and reaction properties package to replace them. I think the parameters are mostly available in the natural gas property package (at least for a really good start, we could expand the species selection over time).

I think the new package should (1) be fully standards compliant (2) allow selection of components present (3) allow selection of ideal or cubic EoS (4) be well documented and (5)be well tested. The goal of this would be to make the combustion gas prop pack easier to find and use and to build up the available core properties models.

@eslickj eslickj added enhancement New feature or request Priority:Low Low Priority Issue or PR labels May 16, 2023
@dallan-keylogic
Copy link
Contributor

It looks like NO is the only component in the flue gas property package not presently supported in the natural gas property package. The Chapman-Enskog calculations for dynamic viscosity and Eucken correlation for thermal conductivity have been implemented in the modular property framework now. I'm not sure the heat capacity and Lennard Jones parameters all match, but I doubt they would produce significantly different results (so long as we're not using them outside their range of validity).

The only annoying thing is that the flue gas property package has mixture viscosity as visc_d instead of visc_d_phase and mixture thermal conductivity as therm_cond instead of therm_cond_phase. That means going through old unit models with find and replace to bring them up to standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority:Low Low Priority Issue or PR
Projects
None yet
Development

No branches or pull requests

5 participants