Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ente-cli 0.2.2 (new formula) #201919

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ente-cli 0.2.2 (new formula) #201919

wants to merge 1 commit into from
+25 −0

Conversation

mathieutu
Copy link

@mathieutu mathieutu commented Dec 20, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Hey,
First new formula here, to add the ente cli tool to Homebrew.

Fix ente-io/ente#706

The brew test does not pass yet (it will in the next release), because of an issue unrelated to the formula (keychain error, that does not happen when executing directly the command). The formula is tested and used in local (macOS arm64).

Thanks,
Mathieu

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Dec 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@mathieutu mathieutu force-pushed the ente-cli branch 2 times, most recently from c493376 to 71160dc Compare December 20, 2024 16:06
@mathieutu
Copy link
Author

The Linux test does not pass, and I can't explain why. I don't have any Linux with homebrew available to test it right now.
If someone wants to help, it'll be much appreciated! 🙂

@mathieutu mathieutu mentioned this pull request Dec 20, 2024
Merged
@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Dec 20, 2024
daeho-ro
daeho-ro reviewed Dec 21, 2024
View reviewed changes
Copy link
Member

@daeho-ro daeho-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your submission, @mathieutu . I left some comments and please take a look.

Formula/e/ente-cli.rb Outdated Show resolved Hide resolved
Formula/e/ente-cli.rb Outdated Show resolved Hide resolved
Formula/e/ente-cli.rb Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 21, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 21, 2024
@mathieutu
Copy link
Author

mathieutu commented Dec 21, 2024 •
edited
Loading

@daeho-ro Thanks for your help.

I've made all the changes, except the test ones:
As said, the cli needs to find a Keychain. A recent change removed the need for the help and version commands, precisely for the homebrew tests. It is on main, but not released yet.

Hence (except if you have any idea):

  • We cannot make them pass right now, although the formula is working well. (I'm using it)
  • We'll not be able to test another command than version or help.

@SMillerDev
Copy link
Member

That's fine, we can wait for the next release.

@chenrui333 chenrui333 marked this pull request as draft December 28, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daeho-ro daeho-ro daeho-ro left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide the CLI via package managers
4 participants
@mathieutu @SMillerDev @daeho-ro @chenrui333